Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix KernelExplainer returning TypeError for certain input #4272

Merged
merged 1 commit into from
Oct 18, 2021
Merged

[REVIEW] Fix KernelExplainer returning TypeError for certain input #4272

merged 1 commit into from
Oct 18, 2021

Conversation

Nanthini10
Copy link
Contributor

Closes #4270

@Nanthini10 Nanthini10 requested a review from a team as a code owner October 7, 2021 19:29
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 7, 2021
@Nanthini10 Nanthini10 added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change bug Something isn't working labels Oct 7, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@51c41c4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #4272   +/-   ##
===============================================
  Coverage                ?   86.07%           
===============================================
  Files                   ?      231           
  Lines                   ?    18694           
  Branches                ?        0           
===============================================
  Hits                    ?    16091           
  Misses                  ?     2603           
  Partials                ?        0
Flag Coverage Δ
dask 47.00% <0.00%> (?)
non-dask 78.76% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c41c4...c3a368b. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Oct 18, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit f6ded9e into rapidsai:branch-21.12 Oct 18, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@Nanthini10
Fix KernelExplainer returning TypeError for certain input (rapidsai#4272
33e14c8 
)

Closes rapidsai#4270

Authors:
  - Nanthini (https://github.com/Nanthini10)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] KernelExplainer returns TypeError for certain input
3 participants
@Nanthini10 @codecov-commenter @dantegd