Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconciling primitives moved to RAFT #4583

Merged
merged 54 commits into from
Oct 19, 2022
Merged

Reconciling primitives moved to RAFT #4583

merged 54 commits into from
Oct 19, 2022

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 16, 2022

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 16, 2022
@cjnolet cjnolet requested review from a team as code owners February 16, 2022 21:02
@cjnolet
Adding knn back
9722d08
@cjnolet
Updating copyrights
8b1de6b
@cjnolet
Adding specializations for knn gtests
5ea7a91
@cjnolet
adding more specializations
11e50ca
@cjnolet
More specializations
7cc8d21
@cjnolet
Updating style
e08dea6
@cjnolet
No longer building brute_force_knn prim anywhere
41a1c5e
@cjnolet
Fixing style
a421dab
@cjnolet
Fixing copyright and removing a couple more distance funcs
bb474e2
@cjnolet
Merge remote-tracking branch 'rapidsai/branch-22.04' into imp-2204-me…
f5b3c66 
…trics_to_raft
@cjnolet
Removing prims moved over to raft
dbde267
@cjnolet
Merge remote-tracking branch 'rapidsai/branch-22.04' into imp-2204-me…
80428f1 
…trics_to_raft
@cjnolet
Reverting get_raft cmake
375142e
@cjnolet
Using distance already specialized
8d57a72
@cjnolet
Merge remote-tracking branch 'rapidsai/branch-22.04' into imp-2204-me…
de49049 
…trics_to_raft
@cjnolet
Merge remote-tracking branch 'rapidsai/branch-22.04' into imp-2204-me…
53d730a 
…trics_to_raft
@cjnolet
Merge remote-tracking branch 'rapidsai/branch-22.04' into imp-2204-me…
004d215 
…trics_to_raft
@cjnolet cjnolet changed the base branch from branch-22.04 to branch-22.06 March 29, 2022 15:18
@cjnolet cjnolet changed the title Moving metrics to RAFT Reconciling primitives moved to RAFT Oct 16, 2022
dantegd
dantegd requested changes Oct 17, 2022
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, just leaving comment to change RAFT back to main

cpp/cmake/thirdparty/get_raft.cmake Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member Author

cjnolet commented Oct 18, 2022

rerun tests

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 18, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@522bed2). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@               Coverage Diff               @@
##             branch-22.12    #4583   +/-   ##
===============================================
  Coverage                ?   79.46%           
===============================================
  Files                   ?      183           
  Lines                   ?    11618           
  Branches                ?        0           
===============================================
  Hits                    ?     9232           
  Misses                  ?     2386           
  Partials                ?        0
Flag Coverage Δ
dask 46.10% <0.00%> (?)
non-dask 68.92% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cjnolet
Copy link
Member Author

cjnolet commented Oct 19, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3479df3 into rapidsai:branch-22.12 Oct 19, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
@cjnolet
Reconciling primitives moved to RAFT (rapidsai#4583)
6a7cf52 
Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Divye Gala (https://github.com/divyegala)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard left review comments

@divyegala divyegala divyegala approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
CMake CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function inactive-30d non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cjnolet @robertmaynard @codecov-commenter @dantegd @ajschmidt8 @divyegala