Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Pyraft and automatically cloning when raft pin changes #4593

Merged
merged 17 commits into from
Feb 23, 2022
Merged

Using Pyraft and automatically cloning when raft pin changes #4593

merged 17 commits into from
Feb 23, 2022
+212 −220

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Feb 20, 2022 •
edited
Loading

This PR depends on rapidsai/raft#520

@cjnolet cjnolet added the improvement Improvement / enhancement to an existing function label Feb 20, 2022
@cjnolet cjnolet requested review from a team as code owners February 20, 2022 01:57
@cjnolet cjnolet added the non-breaking Non-breaking change label Feb 20, 2022
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 20, 2022
@github-actions github-actions bot added the conda conda issue label Feb 20, 2022
@cjnolet cjnolet requested a review from a team as a code owner February 20, 2022 16:08
@cjnolet cjnolet changed the title Using raft conda package for cuml Python build Using Pyraft and automatically cloning when raft pin changes Feb 20, 2022
@cjnolet cjnolet mentioned this pull request Feb 20, 2022
Closed
@cjnolet
Copy link
Member Author

cjnolet commented Feb 21, 2022

rerun tests

@github-actions github-actions bot added the gpuCI gpuCI issue label Feb 21, 2022
@cjnolet
Copy link
Member Author

cjnolet commented Feb 22, 2022

rerun tests

dantegd
dantegd requested changes Feb 22, 2022
View reviewed changes
cpp/cmake/thirdparty/get_raft.cmake Outdated Show resolved Hide resolved
python/setup.py Show resolved Hide resolved
@dantegd dantegd mentioned this pull request Feb 22, 2022
Merged
ajschmidt8
ajschmidt8 approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes.

For what it's worth, the cudf repo has removed all conda/environments/ files besides the CUDA 11.5 one (link) due to enhanced compatibility. It might not hurt for cuml to follow suit. Then there would be less .yml files to maintain.

@cjnolet
Copy link
Member Author

cjnolet commented Feb 22, 2022

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Feb 23, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@b8bc665). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4593   +/-   ##
===============================================
  Coverage                ?   83.88%           
===============================================
  Files                   ?      250           
  Lines                   ?    20062           
  Branches                ?        0           
===============================================
  Hits                    ?    16829           
  Misses                  ?     3233           
  Partials                ?        0
Flag Coverage Δ
dask 45.17% <0.00%> (?)
non-dask 76.98% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8bc665...84ba5ad. Read the comment docs.

@cjnolet
Copy link
Member Author

cjnolet commented Feb 23, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 126c4ef into rapidsai:branch-22.04 Feb 23, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Using Pyraft and automatically cloning when raft pin changes (rapidsa…
56647c0 
…i#4593)

This PR depends on rapidsai/raft#520

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard left review comments

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjnolet @codecov-commenter @robertmaynard @dantegd @ajschmidt8