Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add a dummy argument deep to TargetEncoder.get_params() #4601

Merged
merged 15 commits into from
Feb 24, 2022
Merged

[REVIEW] Add a dummy argument deep to TargetEncoder.get_params() #4601

merged 15 commits into from
Feb 24, 2022

Conversation

daxiongshu
Copy link
Contributor

This is the continuation of PR #4588 to resolve issue #4574

@daxiongshu
Merge pull request #15 from rapidsai/branch-0.15
cf87af4 
sync with upstream
@daxiongshu
Merge pull request #18 from rapidsai/branch-0.17
e3b7848 
sync with upstream
@daxiongshu
Merge pull request #19 from rapidsai/branch-0.17
e6d8ec3 
sync with upstream
@daxiongshu
Merge pull request #20 from rapidsai/branch-0.18
8b1b7c3 
Sync with upstream
@daxiongshu
Merge pull request #22 from rapidsai/branch-0.19
7a51c5a 
sync with upstream
@daxiongshu
Merge pull request #23 from rapidsai/branch-0.19
d7a2f60 
sync with upstream
@daxiongshu
Merge pull request #27 from rapidsai/branch-21.06
6366e9e 
merge with upstream
@daxiongshu
Merge branch 'rapidsai:branch-21.10' into branch-21.10
7757342
@daxiongshu
Merge pull request #32 from rapidsai/branch-22.02
6349067 
sync with upstream
@daxiongshu
Merge branch 'rapidsai:branch-22.02' into branch-22.02
6c408e5
@daxiongshu
Merge branch 'rapidsai:branch-22.04' into branch-22.04
3f4b89d
@daxiongshu
Merge branch 'rapidsai:branch-22.04' into branch-22.04
e305ae3
@daxiongshu
Merge branch 'rapidsai:branch-22.04' into branch-22.04
d3ee54a
@daxiongshu
Merge branch 'rapidsai:branch-22.04' into branch-22.04
39311f9
@daxiongshu
add dummy deep variable
893b82b
@daxiongshu daxiongshu requested a review from a team as a code owner February 23, 2022 15:26
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 23, 2022
@daxiongshu daxiongshu added non-breaking Non-breaking change Cython / Python Cython or Python issue feature request New feature or request and removed Cython / Python Cython or Python issue labels Feb 23, 2022
@daxiongshu daxiongshu changed the title [WIP] Add a dummy argument deep to TargetEncoder.get_params() [REVIEW] Add a dummy argument deep to TargetEncoder.get_params() Feb 23, 2022
@daxiongshu daxiongshu added the 4 - Waiting on Reviewer Waiting for reviewer to review or respond label Feb 23, 2022
@dantegd
Copy link
Member

dantegd commented Feb 24, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7d154b9 into rapidsai:branch-22.04 Feb 24, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@daxiongshu
Add a dummy argument deep to TargetEncoder.get_params() (rapidsai…
e97c9d0 
…#4601)

This is the continuation of PR rapidsai#4588 to resolve issue rapidsai#4574

Authors:
  - Jiwei Liu (https://github.com/daxiongshu)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daxiongshu @dantegd