Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RF: Fix improper documentation in dask-RF #4666

Merged

Conversation

venkywonka
Copy link
Contributor

@venkywonka venkywonka commented Mar 29, 2022

This small PR :

  • Rectifies/clarifies the wrong parameter description for max_depth parameter in RandomForestRegressor and RandomForestClassifier in RF and dask-RF.
  • Corrects a syntax error in dask-rf docs
  • Corrects the max_depth check in RF-python layer

resolves #4623

@venkywonka venkywonka requested a review from a team as a code owner March 29, 2022 07:09
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Mar 29, 2022
@venkywonka venkywonka added bug Something isn't working doc Documentation non-breaking Non-breaking change and removed bug Something isn't working labels Mar 29, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@3798925). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.04    #4666   +/-   ##
===============================================
  Coverage                ?   83.86%           
===============================================
  Files                   ?      251           
  Lines                   ?    20307           
  Branches                ?        0           
===============================================
  Hits                    ?    17030           
  Misses                  ?     3277           
  Partials                ?        0           
Flag Coverage Δ
dask 44.89% <0.00%> (?)
non-dask 77.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3798925...951500f. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Mar 29, 2022

rerun tests

@dantegd
Copy link
Member

dantegd commented Mar 31, 2022

@gpucibot merge

@dantegd
Copy link
Member

dantegd commented Mar 31, 2022

rerun tests

@rapids-bot rapids-bot bot merged commit fcbda03 into rapidsai:branch-22.04 Mar 31, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
This small PR :
* Rectifies/clarifies the wrong parameter description for `max_depth` parameter in `RandomForestRegressor` and `RandomForestClassifier` in RF and dask-RF. 
* Corrects a syntax error in dask-rf docs
* Corrects the `max_depth` check in RF-python layer

resolves rapidsai#4623

Authors:
  - Venkat (https://github.com/venkywonka)

Approvers:
  - Rory Mitchell (https://github.com/RAMitchell)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cython / Python Cython or Python issue doc Documentation non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] GPU Enabled Random Forest Regressor documentation is wrong.
4 participants