Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix identifier collision #4716

Merged
merged 1 commit into from
May 10, 2022
Merged

Fix identifier collision #4716

merged 1 commit into from
May 10, 2022

Conversation

viclafargue
Copy link
Contributor

No description provided.

@viclafargue viclafargue requested a review from a team as a code owner April 28, 2022 10:28
@viclafargue viclafargue changed the title Fix name collision Fix identifier collision Apr 28, 2022
@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 28, 2022
@cjnolet
Copy link
Member

cjnolet commented May 3, 2022

rerun tests

1 similar comment
@viclafargue
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.06@6ca7254). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.06    #4716   +/-   ##
===============================================
  Coverage                ?   88.85%           
===============================================
  Files                   ?      371           
  Lines                   ?    34655           
  Branches                ?        0           
===============================================
  Hits                    ?    30794           
  Misses                  ?     3861           
  Partials                ?        0
Flag Coverage Δ
dask 34.24% <0.00%> (?)
non-dask 84.18% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca7254...cd12cdc. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented May 10, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit b487fdc into rapidsai:branch-22.06 May 10, 2022
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@viclafargue
Fix identifier collision (rapidsai#4716)
8ba9147 
Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4716
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@viclafargue @cjnolet @codecov-commenter @dantegd