Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Update raft pinnings in dev yml files #4778

Merged
merged 4 commits into from
Jun 23, 2022

Conversation

galipremsagar
Copy link
Contributor

This PR updates raft outdated pinnings in dev yml files.

@galipremsagar galipremsagar requested a review from a team as a code owner June 15, 2022 16:03
@github-actions github-actions bot added the conda conda issue label Jun 15, 2022
Copy link
Member

@teju85 teju85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @galipremsagar . But seems like this will require ops review before it can be merged.

@teju85 teju85 added bug Something isn't working improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed conda conda issue improvement Improvement / enhancement to an existing function labels Jun 15, 2022
@github-actions github-actions bot added conda conda issue gpuCI gpuCI issue labels Jun 15, 2022
@galipremsagar galipremsagar self-assigned this Jun 15, 2022
@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jun 15, 2022
@ayushdg
Copy link
Member

ayushdg commented Jun 15, 2022

rerun tests

2 similar comments
@jakirkham
Copy link
Member

rerun tests

@ajschmidt8
Copy link
Member

rerun tests

@cjnolet
Copy link
Member

cjnolet commented Jun 23, 2022

@gpucibot merge

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@d1c61b2). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08    #4778   +/-   ##
===============================================
  Coverage                ?   77.62%           
===============================================
  Files                   ?      180           
  Lines                   ?    11382           
  Branches                ?        0           
===============================================
  Hits                    ?     8835           
  Misses                  ?     2547           
  Partials                ?        0           
Flag Coverage Δ
dask 45.51% <0.00%> (?)
non-dask 67.25% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c61b2...b0028d7. Read the comment docs.

@rapids-bot rapids-bot bot merged commit bd7b128 into rapidsai:branch-22.08 Jun 23, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
This PR updates raft outdated pinnings in dev yml files.

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Thejaswi. N. S (https://github.com/teju85)
  - Ray Douglass (https://github.com/raydouglass)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working conda conda issue gpuCI gpuCI issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants