Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping some hdbscan tests when cuda version is <= 11.2. #4916

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Skipping some hdbscan tests when cuda version is <= 11.2. #4916

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d59aa3
Skipping some hdbscan tests when cuda version is <= 11.2.
cjnolet Oct 6, 2022
d94b21a
Fixing style
cjnolet Oct 6, 2022
f9aa427
Specifying "reason" in skipif
cjnolet Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions cpp/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,14 @@ if(BUILD_CUML_TESTS)
ConfigureTest(PREFIX SG NAME GENETIC_PARAM_TEST PATH sg/genetic/param_test.cu OPTIONAL ML_INCLUDE)
endif()

if(all_algo OR hdbscan_algo)
ConfigureTest(PREFIX SG NAME HDBSCAN_TEST PATH sg/hdbscan_test.cu OPTIONAL ML_INCLUDE)
if("${CMAKE_CUDA_COMPILER_VERSION}" VERSION_LESS_EQUAL "11.2")
# An HDBSCAN gtest is failing w/ CUDA 11.2 for some reason.
if(all_algo OR hdbscan_algo)
ConfigureTest(PREFIX SG NAME HDBSCAN_TEST PATH sg/hdbscan_test.cu OPTIONAL ML_INCLUDE)
endif()
endif()


if(all_algo OR holtwinters_algo)
ConfigureTest(PREFIX SG NAME HOLTWINTERS_TEST PATH sg/holtwinters_test.cu OPTIONAL ML_INCLUDE)
endif()
Expand Down
4 changes: 4 additions & 0 deletions python/cuml/tests/test_hdbscan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,8 @@ def test_hdbscan_blobs(nrows, ncols, nclusters,
np.sort(cuml_agg.cluster_persistence_), rtol=0.01, atol=0.01)


@pytest.mark.skipif(cp.cuda.driver.get_build_version() <= 11020,
"Test failing on driver 11.2")
@pytest.mark.parametrize('dataset', test_datasets.values())
@pytest.mark.parametrize('cluster_selection_epsilon', [0.0, 50.0, 150.0])
@pytest.mark.parametrize('min_samples_cluster_size_bounds', [(150, 150, 0),
Expand Down Expand Up @@ -623,6 +625,8 @@ def test_all_points_membership_vectors_moons(nrows,
sk_membership_vectors)


@pytest.mark.skipif(cp.cuda.driver.get_build_version() <= 11020,
"Test failing on driver 11.2")
@pytest.mark.parametrize('nrows', [1000])
@pytest.mark.parametrize('n_points_to_predict', [200, 500])
@pytest.mark.parametrize('ncols', [10, 25])
Expand Down
2 changes: 2 additions & 0 deletions python/cuml/tests/test_pca.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,8 @@ def test_pca_inverse_transform(datatype, input_type,
5e-5, with_sign=True)


@pytest.mark.skipif(cp.cuda.driver.get_build_version() <= 11020,
"Test failing on driver 11.2")
@pytest.mark.parametrize('nrows', [4000, 8000])
@pytest.mark.parametrize('ncols', [5000, stress_param(20000)])
@pytest.mark.parametrize('whiten', [True, False])
Expand Down