Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up silhouette score into 3 units to improve compilation time #5061

Merged
merged 3 commits into from
Dec 7, 2022

Conversation

wphicks
Copy link
Contributor

@wphicks wphicks commented Dec 5, 2022

Locally, this improves overall build time by 39%

@wphicks wphicks added feature request New feature or request non-breaking Non-breaking change labels Dec 6, 2022
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wphicks
Copy link
Contributor Author

wphicks commented Dec 7, 2022

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.02@1e0f40d). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.02    #5061   +/-   ##
===============================================
  Coverage                ?   79.54%           
===============================================
  Files                   ?      184           
  Lines                   ?    11707           
  Branches                ?        0           
===============================================
  Hits                    ?     9312           
  Misses                  ?     2395           
  Partials                ?        0           
Flag Coverage Δ
dask 46.00% <0.00%> (?)
non-dask 69.08% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dantegd
Copy link
Member

dantegd commented Dec 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4f58721 into rapidsai:branch-23.02 Dec 7, 2022
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
…apidsai#5061)

Locally, this improves overall build time by 39%

Authors:
  - William Hicks (https://github.com/wphicks)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#5061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CUDA/C++ feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants