Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Treelite to 3.1.0 #5146

Merged
merged 5 commits into from
Jan 24, 2023
Merged

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Jan 21, 2023

Needed for #5141

Related: rapidsai/integration#589

@hcho3 hcho3 requested review from a team as code owners January 21, 2023 05:42
@hcho3 hcho3 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 21, 2023
ci/gpu/build.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the ci label Jan 23, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 69.63% // Head: 69.22% // Decreases project coverage by -0.42% ⚠️

Coverage data is based on head (b65526e) compared to base (1bf8f57).
Patch coverage: 95.60% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #5146      +/-   ##
================================================
- Coverage         69.63%   69.22%   -0.42%     
================================================
  Files               192      192              
  Lines             12523    12333     -190     
================================================
- Hits               8720     8537     -183     
+ Misses             3803     3796       -7     
Impacted Files Coverage Δ
python/cuml/internals/__init__.py 100.00% <ø> (ø)
python/cuml/neighbors/__init__.py 100.00% <ø> (ø)
python/cuml/internals/api_decorators.py 97.59% <95.60%> (+1.52%) ⬆️
python/cuml/neighbors/kernel_density.py 84.41% <0.00%> (-3.25%) ⬇️
python/cuml/metrics/pairwise_kernels.py 80.31% <0.00%> (-0.79%) ⬇️
python/cuml/internals/import_utils.py 48.83% <0.00%> (+2.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hcho3
Copy link
Contributor Author

hcho3 commented Jan 24, 2023

@ajschmidt8 Can this PR be merged now?

@ajschmidt8
Copy link
Member

@ajschmidt8 Can this PR be merged now?

Yes, but it needs a review from the rapidsai/cuml-cmake-codeowners team.

@dantegd, can you review?

vyasr
vyasr previously requested changes Jan 24, 2023
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also needs changes to python/setup.py and python/pyproject.toml.

@hcho3 hcho3 requested a review from a team as a code owner January 24, 2023 16:52
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jan 24, 2023
@ajschmidt8
Copy link
Member

queuing this to merge upon re-review by @vyasr

@ajschmidt8
Copy link
Member

/merge

@ajschmidt8 ajschmidt8 dismissed vyasr’s stale review January 24, 2023 23:42

requested changes have been made

@rapids-bot rapids-bot bot merged commit 085ef87 into rapidsai:branch-23.02 Jan 24, 2023
@hcho3 hcho3 deleted the upgrade_treelite branch January 24, 2023 23:53
jakirkham pushed a commit to jakirkham/cuml that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake conda conda issue CUDA/C++ Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants