-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CPU-only build for new FIL #5559
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
requested changes
Aug 24, 2023
robertmaynard
approved these changes
Aug 25, 2023
wphicks
approved these changes
Aug 25, 2023
/ok to test |
hcho3
added
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Aug 28, 2023
This PR has been marked untrusted due to the changes outlined in #5563. It looks like the PR has unsigned commits. You can rebase your branch to sign the unsigned commits to avoid having to solicit an The blog post below outlines how you can do this: |
/ok to test |
btw, there is a useful FAQ about the |
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CMake
CUDA/C++
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command used to test building standalone FIL with
-DCUML_ENABLE_GPU=OFF
:This pull request fixes the CPU-only build with
-DCUML_ENABLE_GPU=OFF
.