Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CPU-only build for new FIL #5559

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Aug 23, 2023

Command used to test building standalone FIL with -DCUML_ENABLE_GPU=OFF:

cmake -DCMAKE_INSTALL_PREFIX=$CONDA_PREFIX -DCMAKE_CUDA_ARCHITECTURES=75 \
  -DCMAKE_BUILD_TYPE=Release -DBUILD_CUML_C_LIBRARY=ON -DSINGLEGPU= \
  -DCUML_ALGORITHMS=fil -DBUILD_CUML_TESTS=OFF -DBUILD_CUML_MPI_COMMS=OFF \
  -DBUILD_CUML_MG_TESTS=OFF -DCUML_USE_TREELITE_STATIC=OFF -DNVTX=OFF \
  -DUSE_CCACHE=OFF -DDISABLE_DEPRECATION_WARNINGS=ON -DCMAKE_PREFIX_PATH=$CONDA_PREFIX  \
  -DCMAKE_MESSAGE_LOG_LEVEL=WARNING -DCUML_ENABLE_GPU=OFF -GNinja ..

This pull request fixes the CPU-only build with -DCUML_ENABLE_GPU=OFF.

@hcho3 hcho3 requested a review from a team as a code owner August 23, 2023 23:31
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 28, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@hcho3
Copy link
Contributor Author

hcho3 commented Aug 28, 2023

/ok to test

@hcho3 hcho3 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 28, 2023
@ajschmidt8
Copy link
Member

This PR has been marked untrusted due to the changes outlined in #5563.

It looks like the PR has unsigned commits.

You can rebase your branch to sign the unsigned commits to avoid having to solicit an /ok to test comment for every subsequent push.

The blog post below outlines how you can do this:

@ajschmidt8
Copy link
Member

/ok to test

@ajschmidt8
Copy link
Member

btw, there is a useful FAQ about the /ok to test comment below:

@dantegd
Copy link
Member

dantegd commented Sep 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit 7813ef8 into rapidsai:branch-23.10 Sep 21, 2023
50 checks passed
@hcho3 hcho3 deleted the fix_cpu_fil branch September 21, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants