Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type hint in split function. #5625

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix type hint in split function. #5625

merged 1 commit into from
Oct 25, 2023

Conversation

trivialfis
Copy link
Member

No description provided.

@trivialfis trivialfis requested a review from a team as a code owner October 19, 2023 10:12
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 19, 2023
@trivialfis trivialfis added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Oct 19, 2023
csadorf
csadorf approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csadorf
Copy link
Contributor

csadorf commented Oct 19, 2023

/merge

@rapids-bot rapids-bot bot merged commit 2b5aa3e into rapidsai:branch-23.12 Oct 25, 2023
53 checks passed
@trivialfis trivialfis deleted the type-hint branch November 22, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csadorf csadorf csadorf approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trivialfis @csadorf