Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix expected ValueError and dask-glm incompatibility #5644

Merged
merged 2 commits into from
Nov 8, 2023
Merged

CI: Fix expected ValueError and dask-glm incompatibility #5644

merged 2 commits into from
Nov 8, 2023
+8 −17

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Nov 6, 2023 •
edited
Loading

  • Expect all supported types and shapes to work with host mem type.
  • Pin dask-glm to 0.3.0.

@csadorf csadorf requested a review from a team as a code owner November 6, 2023 19:47
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Nov 6, 2023
@csadorf csadorf added bug Something isn't working non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Nov 6, 2023
@csadorf csadorf requested a review from a team as a code owner November 8, 2023 16:24
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue labels Nov 8, 2023
@csadorf csadorf changed the title Expect all supported types and shapes to work with host mem type. CI: Fix expected ValueError and dask-glm incompatibility Nov 8, 2023
csadorf
csadorf commented Nov 8, 2023
View reviewed changes
dependencies.yaml
# TODO: remove pin once a release that includes fixes for the error
# is released: https://github.com/rapidsai/cuml/issues/5514
- hdbscan<=0.8.30
- output_types: pyproject
packages:
- dask-glm @ git+https://github.com/dask/dask-glm@main
- dask-glm==0.3.0
# TODO: Can we stop pulling from the master branch now that there was a release in October?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think comment technically belongs to the dask-glm, but I'm hesitant to delay merge of this.

@csadorf
Copy link
Contributor Author

csadorf commented Nov 8, 2023

/merge

@rapids-bot rapids-bot bot merged commit b79c09f into rapidsai:branch-23.12 Nov 8, 2023
52 checks passed
@csadorf csadorf deleted the fix/do-not-expect-value-error-for-support-host-dtypes-and-array-shapes branch November 8, 2023 21:18
@jakirkham jakirkham mentioned this pull request Aug 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
bug Something isn't working conda conda issue Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csadorf @dantegd @AyodeAwe