Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust assumption regarding valid cudf.Series dimensional input. #5654

Conversation

csadorf
Copy link
Contributor

@csadorf csadorf commented Nov 14, 2023

cudf.Series does not accept any multi-dimensional input anymore.

cudf.Series does not accept any multi-dimensional input anymore.
@csadorf csadorf requested a review from a team as a code owner November 14, 2023 17:25
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Nov 14, 2023
@csadorf csadorf added bug Something isn't working breaking Breaking change non-breaking Non-breaking change and removed breaking Breaking change labels Nov 14, 2023
@csadorf csadorf requested a review from vyasr November 14, 2023 17:26
@csadorf
Copy link
Contributor Author

csadorf commented Nov 14, 2023

Note: The change introduced here will not actually be visible in the pr tests since hypothesis tests are only tested nightly unless we temporarily change the actions settings here.

Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Simon! This fix looks correct, having singleton higher dimensions is (intentionally) no longer supported.

@wphicks
Copy link
Contributor

wphicks commented Nov 14, 2023

/merge

@rapids-bot rapids-bot bot merged commit f2e9459 into rapidsai:branch-23.12 Nov 14, 2023
52 checks passed
@csadorf csadorf deleted the fix/do-not-generate-multidimensional-input-for-cudf-series branch November 14, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants