Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable HistGradientBoosting support for now #5744

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

hcho3
Copy link
Contributor

@hcho3 hcho3 commented Feb 1, 2024

Treelite 4.0 added support for HistGradientBoostingClassifier and HistGradientBoostingRegressor. However, it does not yet work with the latest scikit-learn (1.4.0), as it changed the internals of HistGradientBoostingClassifier / HistGradientBoostingRegressor estimators.

For now, throw an exception for HistGradientBoosting estimators.

@hcho3 hcho3 requested a review from a team as a code owner February 1, 2024 22:48
Copy link

copy-pr-bot bot commented Feb 1, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Feb 1, 2024
@hcho3 hcho3 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 1, 2024
@hcho3 hcho3 closed this Feb 2, 2024
@hcho3 hcho3 reopened this Feb 2, 2024
@dantegd
Copy link
Member

dantegd commented Feb 2, 2024

/merge

@rapids-bot rapids-bot bot merged commit e2f8da4 into rapidsai:branch-24.02 Feb 2, 2024
101 of 105 checks passed
@hcho3 hcho3 deleted the sklearn_14 branch February 2, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants