Enable pytest failures on warnings on FutureWarnings (Replace deprecated geopandas.dataset module)
#1360
Conversation
| gpu_dataframe = cuspatial.from_geopandas(host_dataframe) | ||
| # The df size is 8kb of cudf rows and 217kb of the geometry column | ||
| assert gpu_dataframe.memory_usage().sum() == 224945 | ||
| assert gpu_dataframe.memory_usage().sum() == 216793 |
There was a problem hiding this comment.
This test is now essentially the same as test_memory_usage_large below. Is it OK to deduplicate?
There was a problem hiding this comment.
It's the same size because there are no geoseries in the geodataframe other than "geometry", right? The logic is different.
There was a problem hiding this comment.
Ah yes you're correct. gpd.read_file(gpd.datasets.get_path("naturalearth_lowres")) also has pop_est, continent, name, iso_a3, and gdp_md_est columns. Is it OK if this test no longer has those columns?
There was a problem hiding this comment.
This does change the logic, previously the test was also validating that the cudf series are being read with from_geopandas. I don't think another test verifies this.
There was a problem hiding this comment.
Sorry coming back to this now.
cudf series
Did you mean geopandas series? It looks like that may be tested in python/cuspatial/cuspatial/tests/test_from_geopandas.py and I don't see cuspatial.from_geopandas supporting a cudf.Series
| gpu_dataframe = cuspatial.from_geopandas(host_dataframe) | ||
| # The df size is 8kb of cudf rows and 217kb of the geometry column | ||
| assert gpu_dataframe.memory_usage().sum() == 224945 | ||
| assert gpu_dataframe.memory_usage().sum() == 216793 |
There was a problem hiding this comment.
It's the same size because there are no geoseries in the geodataframe other than "geometry", right? The logic is different.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
vyasr
added
improvement
|
/merge |
Description
Continuing the effort in rapidsai/build-planning#26 by enabling
FutureWarningsandDeprecationWarningsto raise errors in the CI.The primary change here is to replace
geopandas.datasetusage with the files used (the data in https://github.com/geopandas/geopandas/tree/main/geopandas/tests/data)Checklist