Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conda: Move cmake to requirements/build #1409

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conda: Move cmake to requirements/build #1409

merged 1 commit into from
Jul 19, 2024

Conversation

jakirkham
Copy link
Member

Description

Previously cmake was added to requirements/host. However it is a build tool. So should be placed in requirements/build. This makes that change in relevant recipes.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jakirkham jakirkham requested a review from a team as a code owner July 19, 2024 19:32
@github-actions github-actions bot added the conda Related to conda and conda configuration label Jul 19, 2024
@jakirkham jakirkham added bug Something isn't working non-breaking Non-breaking change labels Jul 19, 2024
jameslamb
jameslamb approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah good catch, I agree with this

@jakirkham
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 2bbb904 into rapidsai:branch-24.08 Jul 19, 2024
74 checks passed
@jakirkham jakirkham deleted the mv_cmake_bld_conda branch July 19, 2024 23:10
@jakirkham
Copy link
Member Author

Thanks James! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees
No one assigned
Labels
bug Something isn't working conda Related to conda and conda configuration non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakirkham @jameslamb