Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure _from_data accepts columns objects only #1415

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Ensure _from_data accepts columns objects only #1415

merged 3 commits into from
Jul 25, 2024

Conversation

mroeschke
Copy link
Contributor

Description

rapidsai/cudf#16285 makes _from_data explicitly requires the data.values() to all be a ColumnBase. This PR either ensures they are columns or just goes through the normal GeoDataFrame/DataFrame constructor if they are not.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke requested a review from a team as a code owner July 24, 2024 16:35
@github-actions github-actions bot added the Python Related to Python code label Jul 24, 2024
@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 24, 2024
@vyasr
Copy link
Contributor

vyasr commented Jul 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit 7f76560 into rapidsai:branch-24.08 Jul 25, 2024
73 of 74 checks passed
@mroeschke mroeschke deleted the fix/column/constructor branch July 25, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@harrism harrism harrism approved these changes

@thomcom thomcom Awaiting requested review from thomcom thomcom is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mroeschke @vyasr @harrism @bdice @trxcllnt