Readd nyc_taxi_years_correlation.ipynb test
#1421
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakirkham
added
tests
|
Closing in favor of PR: #1422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the notebook tests were taking a long time to complete. Specifically
nyc_taxi_years_correlation.ipynbwas skipped in PR: #1407However the root cause was later understood to be due to this change in cuDF (causing slow downs with Numba arrays): rapidsai/cudf#16277
Since then cuSpatial changed from Numba to CuPy arrays ( #1418 ), which resolves the issue in cuSpatial. Separately cuDF is including changes to fix the issue seen with Numba arrays ( rapidsai/cudf#16436 )
Given all these improvements, think we can add this notebook back to the tests
Checklist