Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cuspatial to use pylibcudf #1440

Merged
merged 5 commits into from
Aug 19, 2024
Merged

Update cuspatial to use pylibcudf #1440

merged 5 commits into from
Aug 19, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Aug 16, 2024

Description

This is necessary for compatibility with cudf after rapidsai/cudf#16299.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 16, 2024
@vyasr vyasr self-assigned this Aug 16, 2024
@vyasr vyasr requested review from a team as code owners August 16, 2024 23:35
@github-actions github-actions bot added the Python Related to Python code label Aug 16, 2024
@github-actions github-actions bot added the conda Related to conda and conda configuration label Aug 17, 2024
bdice
bdice reviewed Aug 17, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs updates in update-version.sh.

python/cuspatial/cuspatial/_lib/cpp/spatial_join.pxd Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from a team as a code owner August 17, 2024 00:32
@github-actions github-actions bot added the ci label Aug 17, 2024
@vyasr
Copy link
Contributor Author

vyasr commented Aug 19, 2024

/merge

@rapids-bot rapids-bot bot merged commit c60bd4d into rapidsai:branch-24.10 Aug 19, 2024
60 checks passed
@vyasr vyasr deleted the feat/pylibcudf branch August 19, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@bdice bdice bdice approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

@thomcom thomcom Awaiting requested review from thomcom thomcom is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

@KyleFromNVIDIA KyleFromNVIDIA Awaiting requested review from KyleFromNVIDIA KyleFromNVIDIA is a code owner automatically assigned from rapidsai/ci-codeowners

Assignees

@vyasr vyasr

Labels
ci conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @harrism @bdice