Add support for Python 3.12 #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
non-breaking
jameslamb
changed the title
|
Restarted CI here now that there are Python 3.12 packages for Will put this up for review once I see enough of CI passing. |
jameslamb
changed the title
jameslamb
requested review from
KyleFromNVIDIA and
bdice
and removed request for
KyleFromNVIDIA
bdice
approved these changes
Sep 10, 2024
bdice
reviewed
Sep 10, 2024
There was a problem hiding this comment.
We may also want to update
cuvs/python/cuvs_bench/pyproject.toml
Lines 28 to 30 in bdea78e
(edit: it was just added 13 hours ago in #275 -- you didn't miss this)
|
I am going to merge this PR and then do a follow-up for updating the new |
|
/merge |
|
Ok thanks very much! Yep I hadn't noticed that new |
|
Follow-up here: #318 |
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
This is a follow-up for #275 and #312. I updated `cuvs_bench`'s `pyproject.toml` to drop Python 3.9 and add Python 3.12. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - James Lamb (https://github.com/jameslamb) URL: #318
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contributes to rapidsai/build-planning#40
This PR adds support for Python 3.12.
Notes for Reviewers
This is part of ongoing work to add Python 3.12 support across RAPIDS.
It temporarily introduces a build/test matrix including Python 3.12, from rapidsai/shared-workflows#213.
A follow-up PR will revert back to pointing at the
branch-24.10branch ofshared-workflowsonce allRAPIDS repos have added Python 3.12 support.
This will fail until all dependencies have been updates to Python 3.12
CI here is expected to fail until all of this project's upstream dependencies support Python 3.12.
This can be merged whenever all CI jobs are passing.