Inner Product for CAGRA-Q #458
Draft
+1,378
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarang-jain
added
feature request
achirkin
requested changes
Nov 12, 2024
cpp/test/neighbors/ann_cagra.cuh
Outdated
| {false}, | ||
| {true}, | ||
| {0.6}); // don't demand high recall without refinement | ||
| {0.55}); // don't demand high recall without refinement |
There was a problem hiding this comment.
Please justify, why reducing the recall here? Why is it not a bug in build or search functions?
Comment on lines
+296
to
+297
| half2 dist = dist_op<half2, DescriptorT::kMetric>( | ||
| q2, c2 + reinterpret_cast<half2(&)[PQ_LEN * vlen / 2]>(vq_vals)[d1]); |
There was a problem hiding this comment.
Please benchmark this before/after the change at least for: single_cta/multi_cta, itopk in range of 32...512, with couple PQ configs. I'm concerned specifically about a possibility of increased register usage and spilling, which could manifest in a significant drop in QPS in some cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #198 (Cosine still pending for CAGRA and CAGRA-Q).