Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate cuda_suffixed=false blocks in dependencies.yaml, fix update-version.sh #1367

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#31.

Follow-up to #1364.

Implements some of the suggestions made in rapidsai/cudf#16183 (after #1364 was already merged):

  • removing cuda_suffixed: "false" blocks in dependencies.yaml wherever they're identical to each other and the fallback matrix
  • changing dependencies.yaml anchors with names like *_conda to *_unsuffixed, to reflect the fact that they're not conda-specific
  • checking that update-version.sh catches all changes to versions

Notes for Reviewers

How I tested this

Looked for update-versions.sh issues manually like this:

git fetch upstream --tags
ci/release/update-version.sh '24.10.0'
git grep -E '24\.8|24\.08|0\.39'

The did find a few problems (like UCX dependency versions not being updated). This fixes those issues.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 24, 2024
@jameslamb jameslamb requested review from a team as code owners July 24, 2024 19:18
@jameslamb jameslamb requested a review from bdice July 24, 2024 19:18
@github-actions github-actions bot added the ci label Jul 24, 2024
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 064e254 into rapidsai:branch-24.08 Jul 24, 2024
29 checks passed
@jameslamb jameslamb deleted the suffix-split-pt2 branch July 24, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants