-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libcudf manifest for wheel build in devcontainer #271
Conversation
features/src/rapids-build-utils/opt/rapids-build-utils/manifest.yaml
Outdated
Show resolved
Hide resolved
features/src/rapids-build-utils/opt/rapids-build-utils/manifest.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The depends
list in Python is for defining the source-built C++ libs that the Python project needs in order to build. Yeah, it could definitely be named better 😅.
Before we merge this we should make sure that we properly handle this use case in all the packages. We're going to have to adapt both the CMake and the python code in the C++ wheels just a little bit (discussed with Paul earlier today). |
I've revived this now that rapidsai/cudf#15483 is just about ready to be merged.
@vyasr could you share the details for this statement? What else needs to be done? |
We talked about this offline. Summarizing here. In wheel builds in Here in devcontainers, I tested this and it looks like it's working as expected. Rebuilt the CUDA 12.0 pip devcontainer from this branch, with only Ran the following: # build libcudf.so + all the Python wheels
build-cudf -j
# test that 'libcudf' is importable
python -c "import libcudf; l = libcudf.load_library(); print(l)"
# None
# test that 'pylibcudf' and 'cudf' are importable
python -c "import pylibcudf;import cudf"
# test that cudf actually works
./cudf/ci/run_cudf_pytests.sh Saw all the expected things:
So I think this can be merged, and should be prior to rapidsai/cudf#15483 being merged. |
Thanks for documenting James. |
I'm not at all sure that I've done this correctly. This is intended to support local development with a devcontainer for the work in rapidsai/cudf#15483