Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve warnings about casing in Dockerfiles #688

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

jameslamb
Copy link
Member

I've been seeing this build warning in logs here:

 2 warnings found (use --debug to expand):
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 37)
 - FromAsCasing: 'as' and 'FROM' keywords' casing do not match (line 70)

(example build link)

That comes from BuildKit's build checks (https://docs.docker.com/reference/build-checks/). Details on that specific warning: https://docs.docker.com/reference/build-checks/from-as-casing/.

This fixes it, to remove a source of noise in logs (and because I agree with the suggestion that capitalizing keywords approves readability a bit).

@jameslamb jameslamb requested a review from a team as a code owner July 3, 2024 15:23
@jameslamb
Copy link
Member Author

The notebook builds should hopefully be fixed once rapidsai/cuspatial#1404 is merged

@jameslamb
Copy link
Member Author

/ok to test

@jameslamb
Copy link
Member Author

A couple of cuspatial notebooks are still failing. I've documented those in rapidsai/cuspatial#1406

@jameslamb jameslamb mentioned this pull request Jul 18, 2024
@jameslamb
Copy link
Member Author

Tests are passing here... looks like the fixes from #690 helped!

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 67a747d into rapidsai:branch-24.08 Jul 18, 2024
34 checks passed
@jameslamb jameslamb deleted the casing branch July 18, 2024 21:37
@jakirkham
Copy link
Member

Thanks James and Kyle! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants