-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable jobs retry & multi-arch builds of succeeding docker image builds #698
Closed
AyodeAwe
wants to merge
12
commits into
rapidsai:branch-24.10
from
AyodeAwe:fix-docker-builds-ops-3417-target-24.08
Closed
enable jobs retry & multi-arch builds of succeeding docker image builds #698
AyodeAwe
wants to merge
12
commits into
rapidsai:branch-24.10
from
AyodeAwe:fix-docker-builds-ops-3417-target-24.08
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AyodeAwe
force-pushed
the
fix-docker-builds-ops-3417-target-24.08
branch
from
August 4, 2024 17:27
b4072ef
to
0b9d3ff
Compare
AyodeAwe
force-pushed
the
fix-docker-builds-ops-3417-target-24.08
branch
from
August 4, 2024 18:20
0b9d3ff
to
90f692d
Compare
AyodeAwe
force-pushed
the
fix-docker-builds-ops-3417-target-24.08
branch
2 times, most recently
from
August 5, 2024 10:17
b4c5882
to
d231a28
Compare
AyodeAwe
force-pushed
the
fix-docker-builds-ops-3417-target-24.08
branch
from
August 5, 2024 10:29
d231a28
to
428bf87
Compare
AyodeAwe
force-pushed
the
fix-docker-builds-ops-3417-target-24.08
branch
from
August 5, 2024 10:48
9d1d9bd
to
bbfda32
Compare
AyodeAwe
force-pushed
the
fix-docker-builds-ops-3417-target-24.08
branch
from
August 5, 2024 17:45
58e0f4b
to
56f636b
Compare
AyodeAwe
force-pushed
the
fix-docker-builds-ops-3417-target-24.08
branch
from
August 5, 2024 18:31
56f636b
to
6673671
Compare
AyodeAwe
commented
Aug 5, 2024
@@ -191,10 +191,11 @@ jobs: | |||
py${{ matrix.PYTHON_VER }}-\ | |||
${{ matrix.ARCH }}" | |||
build-multiarch-manifest: | |||
if: inputs.build_type == 'branch' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will revert this build-multiarch-manifest
job to run only on branches after this PR is reviewed/approved.
AyodeAwe
changed the title
enable jobs retry & multi-arch builds of succeeding image variants
enable jobs retry & multi-arch builds of succeeding docker images
Aug 6, 2024
AyodeAwe
changed the title
enable jobs retry & multi-arch builds of succeeding docker images
enable jobs retry & multi-arch builds of succeeding docker image builds
Aug 6, 2024
PR is continued here (re-targeted for 24.10). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approach:
Here are the new behaviors:
build-multiarch-manifest
no longer depends on thebuild
jobs to all pass before publishing multi-arch images to dockerhub. Once thebuild
job completes (either succeeds or fails), the multiarch job builds and pushes manifests for the succeeding images.test
job still uses the images frombuild
to run tests.delete-temp-images
job will only run AFTERbuild-multiarch-manifest
andtest
jobs succeed.re-run all failed jobs
now. Once all jobs pass, the delete job will trigger.