Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable jobs retry & multi-arch builds of succeeding docker image builds #698

Conversation

AyodeAwe
Copy link
Contributor

@AyodeAwe AyodeAwe commented Aug 4, 2024

Approach:

  1. Enable the construction of multi-architecture images even if not all image build matrices are successful. This allows for the publishing of manifests for the images that have been successfully built without waiting for all builds to complete.
    • In this change, we also modify the multi-arch job to only generate a manifest when the necessary images are available; otherwise, we make the job fail.
  2. Modify the deletion job to execute only after the publishing and tests jobs succeed. This prevents the need to restart all jobs when a single image build job fails.

Here are the new behaviors:

  • The build-multiarch-manifest no longer depends on the build jobs to all pass before publishing multi-arch images to dockerhub. Once the build job completes (either succeeds or fails), the multiarch job builds and pushes manifests for the succeeding images.
  • The test job still uses the images from build to run tests.
  • The delete-temp-images job will only run AFTER build-multiarch-manifest and test jobs succeed.
  • If any jobs fail during the workflow run, we can simply re-run all failed jobs now. Once all jobs pass, the delete job will trigger.

@AyodeAwe AyodeAwe force-pushed the fix-docker-builds-ops-3417-target-24.08 branch from b4072ef to 0b9d3ff Compare August 4, 2024 17:27
@AyodeAwe AyodeAwe force-pushed the fix-docker-builds-ops-3417-target-24.08 branch from 0b9d3ff to 90f692d Compare August 4, 2024 18:20
@AyodeAwe AyodeAwe force-pushed the fix-docker-builds-ops-3417-target-24.08 branch 2 times, most recently from b4c5882 to d231a28 Compare August 5, 2024 10:17
@AyodeAwe AyodeAwe force-pushed the fix-docker-builds-ops-3417-target-24.08 branch from d231a28 to 428bf87 Compare August 5, 2024 10:29
@AyodeAwe AyodeAwe force-pushed the fix-docker-builds-ops-3417-target-24.08 branch from 9d1d9bd to bbfda32 Compare August 5, 2024 10:48
@AyodeAwe AyodeAwe force-pushed the fix-docker-builds-ops-3417-target-24.08 branch from 58e0f4b to 56f636b Compare August 5, 2024 17:45
@AyodeAwe AyodeAwe force-pushed the fix-docker-builds-ops-3417-target-24.08 branch from 56f636b to 6673671 Compare August 5, 2024 18:31
@@ -191,10 +191,11 @@ jobs:
py${{ matrix.PYTHON_VER }}-\
${{ matrix.ARCH }}"
build-multiarch-manifest:
if: inputs.build_type == 'branch'
Copy link
Contributor Author

@AyodeAwe AyodeAwe Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revert this build-multiarch-manifest job to run only on branches after this PR is reviewed/approved.

@AyodeAwe AyodeAwe marked this pull request as ready for review August 5, 2024 20:47
@AyodeAwe AyodeAwe requested a review from a team as a code owner August 5, 2024 20:47
@AyodeAwe AyodeAwe requested review from raydouglass and removed request for a team August 5, 2024 20:47
@AyodeAwe AyodeAwe marked this pull request as draft August 5, 2024 21:08
@AyodeAwe AyodeAwe added the 2 - In Progress Currenty a work in progress label Aug 5, 2024
@AyodeAwe AyodeAwe marked this pull request as ready for review August 6, 2024 12:53
@AyodeAwe AyodeAwe marked this pull request as draft August 6, 2024 13:24
@AyodeAwe AyodeAwe marked this pull request as ready for review August 6, 2024 17:03
@AyodeAwe AyodeAwe changed the title enable jobs retry & multi-arch builds of succeeding image variants enable jobs retry & multi-arch builds of succeeding docker images Aug 6, 2024
@AyodeAwe AyodeAwe changed the title enable jobs retry & multi-arch builds of succeeding docker images enable jobs retry & multi-arch builds of succeeding docker image builds Aug 6, 2024
@AyodeAwe AyodeAwe changed the base branch from branch-24.08 to branch-24.10 August 7, 2024 17:08
@AyodeAwe
Copy link
Contributor Author

AyodeAwe commented Aug 7, 2024

PR is continued here (re-targeted for 24.10).

@AyodeAwe AyodeAwe closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 - In Progress Currenty a work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant