-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Python 3.12 support in install selector #539
Conversation
✅ Deploy Preview for docs-rapids-ai ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
install/install.md
Outdated
@@ -98,7 +98,7 @@ ERROR: No matching distribution found for cudf-cu12 | |||
``` | |||
Check the suggestions below for possible resolutions: | |||
- The pip index has moved from the initial experimental release! Ensure the correct `--extra-index-url=https://pypi.nvidia.com` | |||
- Only Python versions 3.10 and 3.11 are supported | |||
- Only Python versions 3.10, 3.11, and 3.12 are supported |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a change we make post-release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
Even better, how about just directing people to scroll back up to the install selector?
I just proposed that in 5715c9e.
Making the install selector the single source of truth for the range of supported versions would reduce the effort for these upgrades and the risk of this list ever being out of date.
Co-authored-by: Bradley Dice <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion before merging, otherwise LGTM.
Python 3.12 Docker images have now been published: https://github.com/rapidsai/docker/actions/runs/10908818622/job/30279717169 https://hub.docker.com/r/rapidsai/base/tags?page_size=&ordering=&name=py3.12 |
Co-authored-by: Bradley Dice <[email protected]>
This is ready to merge, but I don't have permission to merge it and this repo doesn't use ops-bot/copy-pr-bot. @bdice can you merge this whenever you see this? |
Contributes to rapidsai/build-planning#40
We're adding Python 3.12 support in RAPIDS 24.10. This adds that support to the install selector.
Notes for Reviewers
How I tested this
Built and served the site locally following instructions in https://github.com/rapidsai/docs/blob/main/CONTRIBUTING.md.
Tested the following cases:
"Python 3.9 - 3.12 show up in the selector and Python 3.11 is the default" (click me)
"If you select Python 3.9 then change from `Stable` to `Nightly`, selector automatically switches to Python 3.10" (click me)
"if you select Python 3.12 then change from `Nightly` to `Stable`, selector automatically switches to a supported Python version" (click me)
"the pip support note lists the correct set of Python versions based on whether `Nightly` or `Stable` is selected" (click me)
This isn't ready to merge
Not all RAPIDS nightlies yet support Python 3.12.
Blocked by: