Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Python 3.12 support in install selector #539

Merged
merged 5 commits into from
Sep 18, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Sep 10, 2024

Contributes to rapidsai/build-planning#40

We're adding Python 3.12 support in RAPIDS 24.10. This adds that support to the install selector.

Notes for Reviewers

How I tested this

Built and served the site locally following instructions in https://github.com/rapidsai/docs/blob/main/CONTRIBUTING.md.

Tested the following cases:

"Python 3.9 - 3.12 show up in the selector and Python 3.11 is the default" (click me) Screenshot 2024-09-10 at 3 35 08 PM
"If you select Python 3.9 then change from `Stable` to `Nightly`, selector automatically switches to Python 3.10" (click me) image
"if you select Python 3.12 then change from `Nightly` to `Stable`, selector automatically switches to a supported Python version" (click me) image
"the pip support note lists the correct set of Python versions based on whether `Nightly` or `Stable` is selected" (click me) Screenshot 2024-09-10 at 3 54 41 PM Screenshot 2024-09-10 at 3 55 21 PM

This isn't ready to merge

Not all RAPIDS nightlies yet support Python 3.12.

Blocked by:

@jameslamb jameslamb requested a review from a team as a code owner September 10, 2024 20:57
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for docs-rapids-ai ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 83330be
🔍 Latest deploy log https://app.netlify.com/sites/docs-rapids-ai/deploys/66eaf4ac56fdd10008cee453
😎 Deploy Preview https://deploy-preview-539--docs-rapids-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

_includes/selector.html Outdated Show resolved Hide resolved
@@ -98,7 +98,7 @@ ERROR: No matching distribution found for cudf-cu12
```
Check the suggestions below for possible resolutions:
- The pip index has moved from the initial experimental release! Ensure the correct `--extra-index-url=https://pypi.nvidia.com`
- Only Python versions 3.10 and 3.11 are supported
- Only Python versions 3.10, 3.11, and 3.12 are supported
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a change we make post-release?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

Even better, how about just directing people to scroll back up to the install selector?

I just proposed that in 5715c9e.

Making the install selector the single source of truth for the range of supported versions would reduce the effort for these upgrades and the risk of this list ever being out of date.

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion before merging, otherwise LGTM.

install/install.md Outdated Show resolved Hide resolved
@jameslamb jameslamb changed the title [DO NOT MERGE] add Python 3.12 support in install selector add Python 3.12 support in install selector Sep 17, 2024
@jameslamb
Copy link
Member Author

Co-authored-by: Bradley Dice <[email protected]>
@jameslamb
Copy link
Member Author

This is ready to merge, but I don't have permission to merge it and this repo doesn't use ops-bot/copy-pr-bot.

@bdice can you merge this whenever you see this?

@bdice bdice merged commit c38238f into rapidsai:main Sep 18, 2024
5 checks passed
@jameslamb jameslamb deleted the python-3.12 branch September 18, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants