Move date to build string in conda recipe
#606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR moves the date string from the version to the build string for conda recipes in this repository. This is necessary to ensure that the conda packages resulting from PR builds can be installed in the same environment as nightly conda packages. This is useful for testing purposes. Additionally, this PR adds the `PKG_HASH` value to our build string. This value is a hash computed from the dependency names and versions used to build our packages. Typically the `PKG_HASH` value is included in packages when the build string is omitted, as seen on most `conda-forge` packages. Including it in our build string will help ensure that new packages are published whenever our dependencies change (which is important in the case of shared library updates). xref: rapidsai/rmm#1195
raydouglass
approved these changes
Feb 2, 2023
raydouglass
reviewed
Feb 6, 2023
| if [[ "$BUILD_MODE" = "branch" && "$SOURCE_BRANCH" = branch-* ]] ; then | ||
| export VERSION_SUFFIX=`date +%y%m%d` | ||
| fi | ||
| export RAPIDS_DATE_STRING=$(date +%y%m%d) |
There was a problem hiding this comment.
Should this be git show --no-patch --date=format:'%y%m%d' --format='%cd' like in GHA: https://github.com/rapidsai/gha-tools/blob/main/tools/rapids-env-update#L23
There was a problem hiding this comment.
I will be submitting a PR to gha-tools to replace that line with some logic that gets the date from the corresponding GHA workflow run.
Since some of these repos aren't on GHAs yet, it's fine to just let them use date for now.
Using date will ensure that we can get at least one new package published every day, regardless of whether there were any commits to the repository which is what we want.
raydouglass
approved these changes
Feb 6, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the date string from the version to the build string for conda recipes in this repository.
This is necessary to ensure that the conda packages resulting from PR builds can be installed in the same environment as nightly conda packages, which is useful for testing purposes.
Additionally, this prevents a bug from occurring where the Python builds fail because the date string it computes is different than the one computed by the C++ build, therefore causing the Python build to search for a C++ build artifact that doesn't exist.
xref: rapidsai/rmm#1195