Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run all pytests including subdirectories #158

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Run all pytests including subdirectories #158

merged 5 commits into from
Sep 24, 2024

Conversation

RAMitchell
Copy link
Contributor

@RAMitchell RAMitchell commented Sep 20, 2024 •
edited
Loading

I noticed tests in the model subdirectory were not running and we actually have at least one test failure on main currently.

@jameslamb jameslamb self-requested a review September 20, 2024 16:30
jameslamb
jameslamb approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Giving you an approval so you can merge this whenever you get it working. Totally support this!

I'd wondered about that [!_]**.py pattern but hadn't looked into it yet.

@RAMitchell RAMitchell merged commit 8763b95 into rapidsai:main Sep 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameslamb jameslamb jameslamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RAMitchell @jameslamb