[REVIEW] Fixing Incorrect Deallocation Size and Count Bugs #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
dantegd
approved these changes
Dec 2, 2020
Co-authored-by: Dante Gama Dessavre <[email protected]>
…ret-nv/raft into bug-fix-buffer-deallocation-errors
dantegd
added
5 - Ready to Merge
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the development of this PR: rapidsai/rmm#626, I discovered a couple of issues that prevented the new
TrackingMemoryResourcefrom functioning properly. In some cases,deallocate()was being called with the wrong number of bytes or shouldn't have been called at all. This inhibits theTrackingMemoryResourcefrom functioning correctly since the allocation bytes and deallocation bytes do not match.This PR fixes these issues and adds a unit test to check for it moving forward.