-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Adding simple support for n_clusters=1 in agglomerative clustering and ignoring self-loops #217
Merged
rapids-bot
merged 5 commits into
rapidsai:branch-0.20
from
cjnolet:fea-020-agglomerative_single_cluster
May 12, 2021
Merged
[REVIEW] Adding simple support for n_clusters=1 in agglomerative clustering and ignoring self-loops #217
rapids-bot
merged 5 commits into
rapidsai:branch-0.20
from
cjnolet:fea-020-agglomerative_single_cluster
May 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
3 - Ready for Review
feature request
New feature or request
non-breaking
Non-breaking change
labels
May 4, 2021
cjnolet
changed the title
[REVIEW] Adding simple support for n_clusters=1 in agglomerative clustering
[REVIEW] Adding simple support for n_clusters=1 in agglomerative clustering and ignoring self-loops
May 4, 2021
dantegd
reviewed
May 5, 2021
dantegd
requested changes
May 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished the review, changes looks good, just had a request and the prior suggestion of what's probably wrong with the CI failures
dantegd
added
4 - Waiting on Author
Waiting for author to respond to review
and removed
3 - Ready for Review
labels
May 5, 2021
cjnolet
added
4 - Waiting on Reviewer
Waiting for reviewer to review or respond
and removed
4 - Waiting on Author
Waiting for author to respond to review
labels
May 12, 2021
dantegd
approved these changes
May 12, 2021
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
May 20, 2021
…istances from self-loops (#3824) Closes #3801 Closes #3802 Corresponding RAFT PR: rapidsai/raft#217 Authors: - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: #3824
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…istances from self-loops (rapidsai#3824) Closes rapidsai#3801 Closes rapidsai#3802 Corresponding RAFT PR: rapidsai/raft#217 Authors: - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#3824
dantegd
pushed a commit
to dantegd/raft
that referenced
this pull request
Jul 23, 2024
Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Tarang Jain (https://github.com/tarang-jain) - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai/cuvs#217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4 - Waiting on Reviewer
Waiting for reviewer to review or respond
cpp
feature request
New feature or request
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.