Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Adding simple support for n_clusters=1 in agglomerative clustering and ignoring self-loops #217

Merged

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented May 4, 2021

No description provided.

@cjnolet cjnolet added 3 - Ready for Review feature request New feature or request non-breaking Non-breaking change labels May 4, 2021
@cjnolet cjnolet requested review from divyegala and a team as code owners May 4, 2021 00:21
@github-actions github-actions bot added the cpp label May 4, 2021
@cjnolet cjnolet changed the title [REVIEW] Adding simple support for n_clusters=1 in agglomerative clustering [REVIEW] Adding simple support for n_clusters=1 in agglomerative clustering and ignoring self-loops May 4, 2021
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finished the review, changes looks good, just had a request and the prior suggestion of what's probably wrong with the CI failures

@dantegd dantegd added 4 - Waiting on Author Waiting for author to respond to review and removed 3 - Ready for Review labels May 5, 2021
@cjnolet cjnolet added 4 - Waiting on Reviewer Waiting for reviewer to review or respond and removed 4 - Waiting on Author Waiting for author to respond to review labels May 12, 2021
@dantegd
Copy link
Member

dantegd commented May 12, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7d83f0d into rapidsai:branch-0.20 May 12, 2021
rapids-bot bot pushed a commit to rapidsai/cuml that referenced this pull request May 20, 2021
…istances from self-loops (#3824)

Closes #3801 
Closes #3802 

Corresponding RAFT PR: rapidsai/raft#217

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #3824
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
…istances from self-loops (rapidsai#3824)

Closes rapidsai#3801 
Closes rapidsai#3802 

Corresponding RAFT PR: rapidsai/raft#217

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#3824
dantegd pushed a commit to dantegd/raft that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Waiting on Reviewer Waiting for reviewer to review or respond cpp feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants