Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build C++ wheel #2264

Merged
merged 63 commits into from
May 8, 2024
Merged

Build C++ wheel #2264

merged 63 commits into from
May 8, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 11, 2024

This PR changes wheel building in raft to create a separate C++ wheel that is then found from the Python wheel. The C++ wheel is now a hard dependency of the Python wheel. This allows Python packaging to more closely mirror the structure of our conda packaging, and the way we would normally wish to package these in any other manager. It also allows us to reduce package sizes by allowing better sharing of artifacts between different Python packages that rely on the same C++ components from other packages.

Contributes to rapidsai/build-planning#33

@vyasr vyasr marked this pull request as ready for review May 6, 2024 22:37
@vyasr vyasr requested review from a team as code owners May 6, 2024 22:37
@vyasr
Copy link
Contributor Author

vyasr commented May 6, 2024

The pip devcontainer CI run won't pass until rapidsai/devcontainers#287 is merged, and I plan to wait to merge this PR until #1983 is merged and can be incorporated into this one, but this PR is ready for review now.

Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python approval

@vyasr
Copy link
Contributor Author

vyasr commented May 8, 2024

/merge

@rapids-bot rapids-bot bot merged commit b760453 into rapidsai:branch-24.06 May 8, 2024
61 checks passed
@vyasr vyasr deleted the feat/cpp_wheel branch May 8, 2024 05:09
vyasr added a commit to vyasr/raft that referenced this pull request May 9, 2024
rapids-bot bot pushed a commit that referenced this pull request May 10, 2024
This reverts commit b760453.


The various issues around symbol visibility caused by raft currently supporting a mix of compiled library and header-only usage make this wheel unsafe to use in various environments at the moment. We will revisit this work once all of the compiled components of raft are fully split out into cuvs.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Ray Douglass (https://github.com/raydouglass)

URL: #2305
vyasr added a commit that referenced this pull request May 10, 2024
abc99lr pushed a commit to abc99lr/raft that referenced this pull request May 10, 2024
This PR changes wheel building in raft to create a separate C++ wheel that is then found from the Python wheel. The C++ wheel is now a hard dependency of the Python wheel. This allows Python packaging to more closely mirror the structure of our conda packaging, and the way we would normally wish to package these in any other manager. It also allows us to reduce package sizes by allowing better sharing of artifacts between different Python packages that rely on the same C++ components from other packages.

Contributes to rapidsai/build-planning#33

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)
  - Divye Gala (https://github.com/divyegala)

URL: rapidsai#2264
abc99lr pushed a commit to abc99lr/raft that referenced this pull request May 10, 2024
This reverts commit b760453.


The various issues around symbol visibility caused by raft currently supporting a mix of compiled library and header-only usage make this wheel unsafe to use in various environments at the moment. We will revisit this work once all of the compiled components of raft are fully split out into cuvs.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#2305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CMake cpp feature request New feature or request non-breaking Non-breaking change python
Projects
Development

Successfully merging this pull request may close these issues.

3 participants