[REVIEW] Allow generic reductions for the map then reduce op #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
requested changes
Nov 17, 2020
divyegala
reviewed
Nov 17, 2020
|
Thanks @divyegala for the review, I have updated the ops to allow different output type, and updated the tests. |
tfeher
force-pushed
the
fea-ext-map-generic-reduction
branch
from
a30c273
to
006b03b
Compare
|
@divyegala could you take a look and re-review? Thanks! |
divyegala
approved these changes
Nov 24, 2020
|
All issues are resolved as requested. |
dantegd
approved these changes
Nov 26, 2020
dantegd
pushed a commit
to dantegd/raft
that referenced
this pull request
Jul 23, 2024
Authors: - Divye Gala (https://github.com/divyegala) - Micka (https://github.com/lowener) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai/cuvs#94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mapThenReduce prim, analogous to mapThenSumReduce.