Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add rapids-dependency-file-generator pre-commit hook (#531)
Contributes to rapidsai/shared-workflows#46. Proposes adding a pre-commit hook to run `rapids-dependency-file-generator`. With that change, local `pre-commit` and CI will raise an error if changes to `dependencies.yaml` cause some error from `rapids-dependency-file-generator`. If this project checks any files modified by that tool into source control in the future, it'd also raise an error if any of those files change. This is a bit cheaper way to find out about things like typos, misaligning spacing, etc. than waiting for CI to report it. It's very fast, shouldn't be noticeable in day-to-day development. ### How I tested this Changed an `output: conda` to `output: condafile` (not a valid output type) in `dependencies.yaml`. Ran `pre-commit run --all-files`. Observed the expected failure. <img width="852" alt="Screenshot 2024-01-31 at 9 14 10 AM" src="https://github.com/rapidsai/rapids-cmake/assets/7608904/bd8dc1d6-8e5c-424c-b493-6fd6d5d10dce"> Reverted that change, ran `pre-commit run --all-files` again, saw everything pass. Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) URL: #531
- Loading branch information