Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated tests that test both a device_memory_resource* and a cuda::mr::async_resource_ref #1450

Closed
Tracked by #1445
miscco opened this issue Jan 30, 2024 · 0 comments · Fixed by #1451
Closed
Tracked by #1445

Remove duplicated tests that test both a device_memory_resource* and a cuda::mr::async_resource_ref #1450

miscco opened this issue Jan 30, 2024 · 0 comments · Fixed by #1451
Assignees
@miscco
Labels
feature request New feature or request

Comments

@miscco
Copy link
Contributor

miscco commented Jan 30, 2024

No description provided.

@miscco miscco mentioned this issue Jan 30, 2024
Open
miscco added a commit to miscco/rmm that referenced this issue Jan 30, 2024
@miscco
Remove duplicated memory_resource_tests
5ea3d4a 
Durin the initial introduction of `async_resource_ref` we duplicated all tests that take a `device_memory_resource*`.

Now that we have already some experience with running it in production and are moving more of the interfaces to `async resource_ref` remove those duplicated tests.

closes rapidsai#1450
@miscco miscco mentioned this issue Jan 30, 2024
Merged
3 tasks
@harrism harrism added the feature request New feature or request label Jan 30, 2024
@harrism harrism moved this from Todo to Review in RMM Project Board Jan 30, 2024
rapids-bot bot pushed a commit that referenced this issue Feb 15, 2024
@miscco
Remove duplicated memory_resource_tests (#1451)
ce3af2c 
During the initial introduction of `async_resource_ref` we duplicated all tests that take a `device_memory_resource*`.

Now that we have already some experience with running it in production and are moving more of the interfaces to `async resource_ref` remove those duplicated tests.

closes #1450

Authors:
  - Michael Schellenberger Costa (https://github.com/miscco)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - Bradley Dice (https://github.com/bdice)

URL: #1451
@github-project-automation github-project-automation bot moved this from Review to Done in RMM Project Board Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miscco miscco

Labels
feature request New feature or request
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicated memory_resource_tests miscco/rmm
2 participants
@harrism @miscco