Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly enable Cython docstrings. #1020

Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 7, 2022

This PR embeds signatures in Cython functions and classes so that they'll be accessible for normal Python help. While docstrings are currently present as expected, we still have to provide Cython with the appropriate directives to tell it that we want signatures.

@vyasr vyasr added bug Something isn't working 3 - Ready for review Ready for review by team CMake non-breaking Non-breaking change labels Apr 7, 2022
@vyasr vyasr requested a review from a team as a code owner April 7, 2022 18:28
@vyasr vyasr self-assigned this Apr 7, 2022
@github-actions github-actions bot added the Python Related to RMM Python API label Apr 7, 2022
@shwina
Copy link
Contributor

shwina commented Apr 7, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 23d98ba into rapidsai:branch-22.06 Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for review Ready for review by team bug Something isn't working CMake non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants