Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ninja in GitHub Actions #1142

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Use ninja in GitHub Actions #1142

merged 1 commit into from
Oct 27, 2022

Conversation

ajschmidt8
Copy link
Member

Description

This PR adds an environment variable to ensure that CMake uses ninja as its build system, which was the behavior in Jenkins.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@ajschmidt8
Use ninja in GitHub Actions
943be55 
This PR adds an environment variable to ensure that CMake uses `ninja` as its build system, which was the behavior in Jenkins.
@ajschmidt8 ajschmidt8 added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Oct 27, 2022
@ajschmidt8 ajschmidt8 marked this pull request as ready for review October 27, 2022 19:55
@ajschmidt8 ajschmidt8 requested a review from a team as a code owner October 27, 2022 19:55
@github-actions github-actions bot added the gpuCI label Oct 27, 2022
@ajschmidt8
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ca53a5e into rapidsai:branch-22.12 Oct 27, 2022
@ajschmidt8 ajschmidt8 deleted the ninja branch October 27, 2022 20:40
@jakirkham
Copy link
Member

Should we do this with the Conda packages as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevagh sevagh sevagh approved these changes

Assignees
No one assigned
Labels
gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajschmidt8 @jakirkham @sevagh