-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split up CUDA-suffixed dependencies in dependencies.yaml #1627
Conversation
It's a bit late for 24.08... better get it out of draft ASAP. |
Yep understood! This should be ready to go, low-risk, and non-controversial... just opened it in draft until I could see CI pass, to minimize notifications for people. Enough tests have passed that I'm confident in pulling this out of draft now. Hopefully the CI runners will work through their backlog soon 😬 |
I've updated this based on the suggestions from rapidsai/cudf#16183. Ran the following to check git fetch upstream --tags
ci/release/update-version.sh '24.10.00'
git grep -E '24\.8|24\.08|0\.39' No changes to that script were needed. |
packages: | ||
- librmm-cu11==24.8.*,>=0.0.0a0 | ||
- matrix: | ||
- matrix: null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to be consistent about when we do and don't use inline tables (some of the other PRs for this did), but nbd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess in all those cases the package list only contained YAML anchors and not actual package specs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah exactly, that was the difference here.>
inside a []
causes a YAML-parsing error, and when I surrounded this in single quotes that caused some of the pattern-matching in ci/release/update-version.sh
to break. I thought just splitting it out to an indented map was simpler and safer than modifying update-version.sh
to account for the possibility of quotes.
/merge |
Description
Contributes to rapidsai/build-planning#31
In short, RAPIDS DLFW builds want to produce wheels with unsuffixed dependencies, e.g.
cudf
depending onrmm
, notrmm-cu12
.This PR is part of a series across all of RAPIDS to try to support that type of build by setting up CUDA-suffixed and CUDA-unsuffixed dependency lists in
dependencies.yaml
.For more details, see:
Notes for Reviewers
Why target 24.08?
This is targeting 24.08 because:
Checklist