Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Merge Conflicts [skip ci] #786

Merged
merged 8 commits into from
May 24, 2021
63 changes: 56 additions & 7 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,62 @@

Please see https://github.com/rapidsai/rmm/releases/tag/v21.08.0a for the latest changes to this development branch.

# RMM 0.20.0 (Date TBD)

Please see https://github.com/rapidsai/rmm/releases/tag/v0.20.0a for the latest changes to this development branch.

# RMM 0.19.0 (Date TBD)

Please see https://github.com/rapidsai/rmm/releases/tag/v0.19.0a for the latest changes to this development branch.
# RMM 21.06.00 (Date TBD)

Please see https://github.com/rapidsai/rmm/releases/tag/v21.06.00a for the latest changes to this development branch.

# RMM 0.19.0 (21 Apr 2021)

## 🚨 Breaking Changes

- Avoid potential race conditions in device_scalar/device_uvector setters ([#725](https://github.com/rapidsai/rmm/pull/725)) [@harrism](https://github.com/harrism)

## 🐛 Bug Fixes

- Fix typo in setup.py ([#746](https://github.com/rapidsai/rmm/pull/746)) [@galipremsagar](https://github.com/galipremsagar)
- Revert "Update `rmm` conda recipe pinning of `librmm`" ([#743](https://github.com/rapidsai/rmm/pull/743)) [@raydouglass](https://github.com/raydouglass)
- Update `rmm` conda recipe pinning of `librmm` ([#738](https://github.com/rapidsai/rmm/pull/738)) [@mike-wendt](https://github.com/mike-wendt)
- RMM doesn't require the CUDA language to be enabled by consumers ([#737](https://github.com/rapidsai/rmm/pull/737)) [@robertmaynard](https://github.com/robertmaynard)
- Fix setup.py to work in a non-conda environment setup ([#733](https://github.com/rapidsai/rmm/pull/733)) [@galipremsagar](https://github.com/galipremsagar)
- Fix auto-detecting GPU architectures ([#727](https://github.com/rapidsai/rmm/pull/727)) [@trxcllnt](https://github.com/trxcllnt)
- CMAKE_CUDA_ARCHITECTURES doesn't change when build-system invokes cmake ([#726](https://github.com/rapidsai/rmm/pull/726)) [@robertmaynard](https://github.com/robertmaynard)
- Ship memory_resource_wrappers.hpp as package_data ([#715](https://github.com/rapidsai/rmm/pull/715)) [@shwina](https://github.com/shwina)
- Only include SetGPUArchs in the top-level CMakeLists.txt ([#713](https://github.com/rapidsai/rmm/pull/713)) [@trxcllnt](https://github.com/trxcllnt)
- Fix unknown CMake command "CPMFindPackage" ([#699](https://github.com/rapidsai/rmm/pull/699)) [@standbyme](https://github.com/standbyme)

## 📖 Documentation

- Fix host_memory_resource signature typo ([#728](https://github.com/rapidsai/rmm/pull/728)) [@miguelusque](https://github.com/miguelusque)

## 🚀 New Features

- Clarify log file name behaviour in docs ([#722](https://github.com/rapidsai/rmm/pull/722)) [@shwina](https://github.com/shwina)
- Add Cython definitions for device_uvector ([#720](https://github.com/rapidsai/rmm/pull/720)) [@shwina](https://github.com/shwina)
- Python bindings for `cuda_async_memory_resource` ([#718](https://github.com/rapidsai/rmm/pull/718)) [@shwina](https://github.com/shwina)

## 🛠️ Improvements

- Fix cython tests ([#749](https://github.com/rapidsai/rmm/pull/749)) [@galipremsagar](https://github.com/galipremsagar)
- Add requirements for rmm ([#739](https://github.com/rapidsai/rmm/pull/739)) [@galipremsagar](https://github.com/galipremsagar)
- device_uvector can be used within thrust::optional ([#734](https://github.com/rapidsai/rmm/pull/734)) [@robertmaynard](https://github.com/robertmaynard)
- arena_memory_resource optimization: disable tracking allocated blocks by default ([#732](https://github.com/rapidsai/rmm/pull/732)) [@rongou](https://github.com/rongou)
- Remove CMAKE_CURRENT_BINARY_DIR path in rmm's target_include_directories ([#731](https://github.com/rapidsai/rmm/pull/731)) [@trxcllnt](https://github.com/trxcllnt)
- set CMAKE_CUDA_ARCHITECTURES to OFF instead of undefined ([#729](https://github.com/rapidsai/rmm/pull/729)) [@trxcllnt](https://github.com/trxcllnt)
- Avoid potential race conditions in device_scalar/device_uvector setters ([#725](https://github.com/rapidsai/rmm/pull/725)) [@harrism](https://github.com/harrism)
- Update Changelog Link ([#723](https://github.com/rapidsai/rmm/pull/723)) [@ajschmidt8](https://github.com/ajschmidt8)
- Prepare Changelog for Automation ([#717](https://github.com/rapidsai/rmm/pull/717)) [@ajschmidt8](https://github.com/ajschmidt8)
- Update 0.18 changelog entry ([#716](https://github.com/rapidsai/rmm/pull/716)) [@ajschmidt8](https://github.com/ajschmidt8)
- Simplify cmake cuda architectures handling ([#709](https://github.com/rapidsai/rmm/pull/709)) [@robertmaynard](https://github.com/robertmaynard)
- Build only `compute` for the newest arch in CMAKE_CUDA_ARCHITECTURES ([#706](https://github.com/rapidsai/rmm/pull/706)) [@robertmaynard](https://github.com/robertmaynard)
- ENH Build with Ninja & Pass ccache variables to conda recipe ([#705](https://github.com/rapidsai/rmm/pull/705)) [@dillon-cullinan](https://github.com/dillon-cullinan)
- pool_memory_resource optimization: disable tracking allocated blocks by default ([#702](https://github.com/rapidsai/rmm/pull/702)) [@harrism](https://github.com/harrism)
- Allow the build directory of rmm to be used for `find_package(rmm)` ([#698](https://github.com/rapidsai/rmm/pull/698)) [@robertmaynard](https://github.com/robertmaynard)
- Adds a linear accessor to RMM cuda stream pool ([#696](https://github.com/rapidsai/rmm/pull/696)) [@afender](https://github.com/afender)
- Fix merge conflicts for #692 ([#694](https://github.com/rapidsai/rmm/pull/694)) [@ajschmidt8](https://github.com/ajschmidt8)
- Fix merge conflicts for #692 ([#693](https://github.com/rapidsai/rmm/pull/693)) [@ajschmidt8](https://github.com/ajschmidt8)
- Remove C++ Wrappers in `memory_resource_adaptors.hpp` Needed by Cython ([#662](https://github.com/rapidsai/rmm/pull/662)) [@mdemoret-nv](https://github.com/mdemoret-nv)
- Improve Cython Lifetime Management by Adding References in `DeviceBuffer` ([#661](https://github.com/rapidsai/rmm/pull/661)) [@mdemoret-nv](https://github.com/mdemoret-nv)
- Add support for streams in CuPy allocator ([#654](https://github.com/rapidsai/rmm/pull/654)) [@pentschev](https://github.com/pentschev)

# RMM 0.18.0 (24 Feb 2021)

Expand Down
2 changes: 1 addition & 1 deletion ci/gpu/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ conda activate rapids
gpuci_conda_retry install rapids-build-env=${MINOR_VERSION}.*

# https://docs.rapids.ai/maintainers/depmgmt/
# conda remove -f rapids-build-env
# conda remove --force rapids-build-env
# gpuci_conda_retry install "your-pkg=1.0.0"

gpuci_logger "Check versions"
Expand Down
2 changes: 1 addition & 1 deletion cmake/Modules/RMM_thirdparty.cmake
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# spdlog

set(RMM_MIN_VERSION_spdlog 1.7.0)
set(RMM_MIN_VERSION_spdlog 1.8.5)

if(NOT TARGET spdlog)
CPMFindPackage(
Expand Down
8 changes: 5 additions & 3 deletions cmake/install/FindThrust.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,11 @@ if(Thrust_FOUND)
# target since that'll use -isystem, leading to the wrong search order with nvcc
function(thrust_create_target tgt)
if(NOT TARGET ${tgt})
add_library(thrust_internal INTERFACE)
set_target_properties(thrust_internal PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
"${Thrust_INCLUDE_DIRS}")
if(NOT TARGET thrust_internal)
add_library(thrust_internal INTERFACE)
set_target_properties(thrust_internal PROPERTIES INTERFACE_INCLUDE_DIRECTORIES
"${Thrust_INCLUDE_DIRS}")
endif()
add_library(${tgt} ALIAS thrust_internal)
endif()
endfunction()
Expand Down
2 changes: 1 addition & 1 deletion conda/environments/rmm_dev_cuda10.1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ dependencies:
- cffi>=1.10.0
- pytest
- cudatoolkit=10.1
- spdlog=1.7.0
- spdlog>=1.8.5,<2.0.0a0
- cython>=0.29,<0.30
2 changes: 1 addition & 1 deletion conda/environments/rmm_dev_cuda10.2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ dependencies:
- cffi>=1.10.0
- pytest
- cudatoolkit=10.2
- spdlog=1.7.0
- spdlog>=1.8.5,<2.0.0a0
- cython>=0.29,<0.30
2 changes: 1 addition & 1 deletion conda/environments/rmm_dev_cuda11.0.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ dependencies:
- cffi>=1.10.0
- pytest
- cudatoolkit=11.0
- spdlog=1.7.0
- spdlog>=1.8.5,<2.0.0a0
- cython>=0.29,<0.30
4 changes: 2 additions & 2 deletions conda/recipes/librmm/meta.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright (c) 2018, NVIDIA CORPORATION.

{% set version = environ.get('GIT_DESCRIBE_TAG', '0.0.0.dev').lstrip('v') + environ.get('VERSION_SUFFIX', '') %}
{% set cuda_version='.'.join(environ.get('CUDA_VERSION', '9.2').split('.')[:2]) %}
{% set cuda_version='.'.join(environ.get('CUDA', '9.2').split('.')[:2]) %}
package:
name: librmm
version: {{ version }}
Expand Down Expand Up @@ -35,7 +35,7 @@ requirements:
- cudatoolkit {{ cuda_version }}.*
run:
- {{ pin_compatible('cudatoolkit', max_pin='x.x') }}
- spdlog=1.7.0
- spdlog>=1.8.5,<2.0.0a0

test:
commands:
Expand Down
4 changes: 2 additions & 2 deletions conda/recipes/rmm/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

{% set version = environ.get('GIT_DESCRIBE_TAG', '0.0.0.dev').lstrip('v') + environ.get('VERSION_SUFFIX', '') %}
{% set py_version=environ.get('CONDA_PY', 35) %}
{% set cuda_version='.'.join(environ.get('CUDA_VERSION', '10.1').split('.')[:2]) %}
{% set cuda_version='.'.join(environ.get('CUDA', '10.1').split('.')[:2]) %}

package:
name: rmm
Expand All @@ -27,7 +27,7 @@ requirements:
- librmm {{ version }}
- setuptools
- cython >=0.29,<0.30
- spdlog=1.7.0
- spdlog>=1.8.5,<2.0.0a0
- cudatoolkit {{ cuda_version }}.*
run:
- python
Expand Down