Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spdlog to rmm-exports if found by CPM #810

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Add spdlog to rmm-exports if found by CPM #810

merged 1 commit into from
Jun 23, 2021

Conversation

trxcllnt
Copy link
Contributor

Fixes an issue using RMM's build directory as its install location fails because spdlog's spdlogConfigTargets.cmake isn't located in the _deps/spdlog-build directory.

@trxcllnt trxcllnt requested a review from a team as a code owner June 23, 2021 15:41
@github-actions github-actions bot added the CMake label Jun 23, 2021
@robertmaynard robertmaynard added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 23, 2021
@trxcllnt
Copy link
Contributor Author

@gpucibot merge

1 similar comment
@robertmaynard
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 55a9c0d into rapidsai:branch-21.08 Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
CMake improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trxcllnt @robertmaynard