Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix align_up namespace in aligned_resource_adaptor.hpp #820

Merged
merged 1 commit into from
Jul 17, 2021
Merged

fix align_up namespace in aligned_resource_adaptor.hpp #820

merged 1 commit into from
Jul 17, 2021

Conversation

rongou
Copy link
Contributor

@rongou rongou commented Jul 15, 2021

Fixes #819

@rongou rongou requested a review from a team as a code owner July 15, 2021 16:41
@github-actions github-actions bot added the cpp Pertains to C++ code label Jul 15, 2021
@rongou rongou added 3 - Ready for review Ready for review by team bug Something isn't working non-breaking Non-breaking change labels Jul 15, 2021
@harrism
Copy link
Member

harrism commented Jul 16, 2021

Why did this work in CI before? Is this resource not tested?

@rongou
Copy link
Contributor Author

rongou commented Jul 16, 2021

It is tested and it works fine with gcc, I think it's just some other compilers that might get confused.

@codereport
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2179ffd into rapidsai:branch-21.08 Jul 17, 2021
@codereport codereport added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for review Ready for review by team labels Jul 17, 2021
@rongou rongou deleted the branch-21.08 branch October 8, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codereport codereport codereport approved these changes

@harrism harrism harrism approved these changes

@cwharris cwharris Awaiting requested review from cwharris

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working cpp Pertains to C++ code non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] aligned_resource_adaptor.hpp doesn't compile
3 participants
@rongou @harrism @codereport