tweak the arena mr to reduce fragmentation #845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rongou
added
3 - Ready for review
harrism
requested changes
Aug 17, 2021
abellina
reviewed
Aug 18, 2021
Co-authored-by: Mark Harris <[email protected]>
|
Also noticed copyrights need to be updated to include 2021. |
harrism
reviewed
Aug 23, 2021
|
@rongou are you still working on this? |
|
Got busy with some other things. Will try to get back to this next week. |
harrism
approved these changes
Sep 9, 2021
codereport
reviewed
Sep 9, 2021
Comment on lines
379
to
382
| std::size_t total_upstream{}; | ||
| for (auto const& b : upstream_blocks_) { | ||
| total_upstream += b.size(); | ||
| } |
There was a problem hiding this comment.
Use accumulate same as above.
|
@codereport please take another look. |
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing out-of-memory errors in some cases when there are plenty of free space available, probably due to memory fragmentation. This PR attempts to address the issue:
With these changes I can run those TPC-DS queries successfully with very high concurrency that previously would run out of memory. Need to do some more benchmarking to verify the behavior.
@abellina