Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct namespace usage in host memory resources #872

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Correct namespace usage in host memory resources #872

merged 1 commit into from
Sep 17, 2021

Conversation

divyegala
Copy link
Member

Host memory resources were calling into detail as detail::, but due to relative namespacing, it was trying to look in rmm::mr::host::detail::.... Corrected these usages to rmm::detail::...

@divyegala divyegala requested a review from a team as a code owner September 16, 2021 19:23
@github-actions github-actions bot added the cpp Pertains to C++ code label Sep 16, 2021
@harrism harrism added bug Something isn't working non-breaking Non-breaking change labels Sep 17, 2021
@harrism
Copy link
Member

harrism commented Sep 17, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e4bf138 into rapidsai:branch-21.10 Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad approved these changes

@harrism harrism harrism approved these changes

@rongou rongou rongou approved these changes

Assignees
No one assigned
Labels
bug Something isn't working cpp Pertains to C++ code non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@divyegala @harrism @rongou @jrhemstad