Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace to_device() in docs with DeviceBuffer.to_device() #902

Merged
merged 2 commits into from
Nov 1, 2021
Merged

Replace to_device() in docs with DeviceBuffer.to_device() #902

merged 2 commits into from
Nov 1, 2021

Conversation

shwina
Copy link
Contributor

@shwina shwina commented Nov 1, 2021 •
edited by harrism
Loading

Fixes #668

@shwina shwina requested a review from a team as a code owner November 1, 2021 21:14
@github-actions github-actions bot added the Python Related to RMM Python API label Nov 1, 2021
@shwina shwina added the doc Documentation label Nov 1, 2021
@shwina shwina added the non-breaking Non-breaking change label Nov 1, 2021
@shwina
Copy link
Contributor Author

shwina commented Nov 1, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit d8c3fb7 into branch-21.12 Nov 1, 2021
@wence- wence- mentioned this pull request May 10, 2022
Merged
rapids-bot bot pushed a commit that referenced this pull request May 10, 2022
@wence-
Replace to_device with DeviceBuffer.to_device (#1033)
3b0f7fc 
As well as in the basic python docs, `to_device` was also
explicitly referenced in the README. Follows up #902 which
missed this reference.

Authors:
  - Lawrence Mitchell (https://github.com/wence-)

Approvers:
  - https://github.com/jakirkham

URL: #1033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@harrism harrism harrism approved these changes

Assignees
No one assigned
Labels
doc Documentation non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] RMM Python Docs use nonexistant rmm.to_device() method
3 participants
@shwina @harrism @galipremsagar