Use Cython's array to back Py_ssize_t[::1]
#307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `Array`, `Py_ssize_t[::1]` objects are currently backed by CPython `array`'s with some internal bits expressed in Cython. However these are not compatible with Python's Limited API and Stable ABI. To address that, switch to Cython's own`array` type. As this is baked into Cython and doesn't use anything special, it is compatible with Python's Limited API and Stable ABI. https://cython.readthedocs.io/en/latest/src/userguide/memoryviews.html#cython-arrays
jakirkham
added
improvement
|
Did a simple benchmark in this comment: rapidsai/kvikio#504 (comment) Basically this is a bit slower, but no more than the time of 1-2 attribute accesses on an object |
pentschev
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
I tried to do some benchmark with UCX-Py (not UCXX, as it should have similar impact) but the variability prevents us from reaching any conclusive results regarding performance before and after this change, where sometimes results are better before and other times after, therefore I think it doesn't impose any negative impact that would be noticeable in practical use cases.
LGTM, thanks @jakirkham .
|
/merge |
|
Thanks Peter! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
Array,Py_ssize_t[::1]objects are currently backed by CPythonarray's with some internal bits expressed in Cython. However these are not compatible with Python's Limited API and Stable ABI. To address that, switch to Cython's ownarraytype. As this is baked into Cython and doesn't use anything special, it is compatible with Python's Limited API and Stable ABI.xref: rapidsai/build-planning#42