Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA workflow stub for uploading packages #59

Merged
merged 4 commits into from
Apr 18, 2024

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham commented Apr 18, 2024

We would like to use the workflow_run event to add a custom conda package upload workflow after packages are built. However in the GitHub Actions (GHA) docs, it states that workflow_run events will only be triggered if the workflow is on the default branch. Though we have not figured out completely how to implement this workflow and don't want to add it untested to main. So simply add a stub workflow with the workflow_run event. This way GHA will run the workflow, but we can start customizing it in a PR instead where we can actually test its behavior.

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_run

@jakirkham jakirkham force-pushed the jakirkham/add_gha_upload_stub branch from d143b73 to 9efb21c Compare April 18, 2024 21:34
In order to customize package uploading behavior for RAPIDS needs, start
with a stub workflow that can be used spell out this uploading behavior.
@jakirkham jakirkham force-pushed the jakirkham/add_gha_upload_stub branch from 9efb21c to b56ff16 Compare April 18, 2024 21:37
This reverts commit b56ff16.

As the GHA workflow seems to work as expected, revert the changes need
to make the test.
As GHA will only run the `workflow_run` event for workflows on the
default branch, go ahead and add the event to this stub workflow. That
way it can merged into the default branch without causing issues. We can
then spell out this workflow in a new PR to try and get the behavior we
want.
@jakirkham jakirkham changed the title Create a stub for the upload workflow Add GHA workflow stub for uploading packages Apr 18, 2024
@jakirkham jakirkham marked this pull request as ready for review April 18, 2024 21:45
@jakirkham jakirkham requested a review from hcho3 as a code owner April 18, 2024 21:45
@jakirkham
Copy link
Member Author

Ignoring CI as this is just about setting up this upload workflow stub

Will be looking at CI more closely in a subsequent PR where this can be tested out more

@jakirkham jakirkham merged commit 9c5cb3c into main Apr 18, 2024
0 of 8 checks passed
@jakirkham jakirkham deleted the jakirkham/add_gha_upload_stub branch April 18, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant