Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ViewComponentColumn #1779

Merged
merged 6 commits into from
Jul 19, 2024

Conversation

lrljoe
Copy link
Sponsor Collaborator

@lrljoe lrljoe commented Jul 16, 2024

This corrects the original behaviour, and ensures that a View Component Column loads the View Component, and boots it correctly.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Please upload report for BASE (development@3f96b36). Learn more about missing BASE report.

Files Patch % Lines
src/Views/Columns/ViewComponentColumn.php 0.00% 18 Missing ⚠️
...iews/Traits/Helpers/ViewComponentColumnHelpers.php 0.00% 4 Missing ⚠️
...Configuration/ViewComponentColumnConfiguration.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             development    #1779   +/-   ##
==============================================
  Coverage               ?   86.44%           
  Complexity             ?     1491           
==============================================
  Files                  ?      139           
  Lines                  ?     3476           
  Branches               ?        0           
==============================================
  Hits                   ?     3005           
  Misses                 ?      471           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit e959209 into rappasoft:development Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The component class constructor doesn't seem to run when using ComponentColumn
1 participant