-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OMX_GetParameter OMX_IndexParamVideoBitrate set zeros version, size, port #163
Comments
And if getting that parameter is not supported the corresponding error should be returned |
Getting this parameter is supported (by video_encode). OpenMax guy says this does work in general. |
OMX_VIDEO_PARAM_BITRATETYPE bitrate_param; // set up to init values like version, size , port,... But after this all values in bitrate_param looks like after nSize == 0 nVersion ==0 , nPortIndex == 0,.... |
@xlazom00 |
@xlazom00 |
Confirmed. A bug report is opened in our jira bugtracker. |
@popcornmix has this been resolved in the jira bugtracker? |
Pretty sure this has been fixed. @xlazom00 can you still reproduce this? |
Just looking at the source and I don't think this is fixed. |
kernel: bcm2708-spi: Don't use static pin configuration with DT kernel: bcm2708-i2s: Don't use static pin configuration with DT kernel: gpio-poweroff: Allow it to work on Raspberry Pi See: raspberrypi/linux#1031 kernel: BCM270X_DT: Create a core clock, use it for SPI and sdhost kernel: BCM270X_DT: Add overlay to enable uart1 See: raspberrypi/linux#1008 kernel: config: Enable ZSMALLOC, ZRAM and PGTABLE_MAPPING See: Hexxeh/rpi-firmware#85 firmware: arm_loader: Support initialising vchiq through mailbox property interface See: raspberrypi/linux#1026 firmware: drivers/usb: Reduce busy-wait to sensible timeout See: raspberrypi/linux#1026 firmware: video_encode: Initialise headers for video_bitrate See: #163 firmware: arm_loader: Use the new core_freq DT parameter if present firmware: arm_loader: Set the uart1_clkrate DT property from core_freq firmware: arm_cursor: Better handling of a second app requesting a cursor firmware: arm: Tidy up setting of arm_control and arm_bash
kernel: bcm2708-spi: Don't use static pin configuration with DT kernel: bcm2708-i2s: Don't use static pin configuration with DT kernel: gpio-poweroff: Allow it to work on Raspberry Pi See: raspberrypi/linux#1031 kernel: BCM270X_DT: Create a core clock, use it for SPI and sdhost kernel: BCM270X_DT: Add overlay to enable uart1 See: raspberrypi/linux#1008 kernel: config: Enable ZSMALLOC, ZRAM and PGTABLE_MAPPING See: #85 firmware: arm_loader: Support initialising vchiq through mailbox property interface See: raspberrypi/linux#1026 firmware: drivers/usb: Reduce busy-wait to sensible timeout See: raspberrypi/linux#1026 firmware: video_encode: Initialise headers for video_bitrate See: raspberrypi/firmware#163 firmware: arm_loader: Use the new core_freq DT parameter if present firmware: arm_loader: Set the uart1_clkrate DT property from core_freq firmware: arm_cursor: Better handling of a second app requesting a cursor firmware: arm: Tidy up setting of arm_control and arm_bash
I've added @6by9's patch in latest rpi-update - does that help? |
kernel: bcm2708-spi: Don't use static pin configuration with DT kernel: bcm2708-i2s: Don't use static pin configuration with DT kernel: gpio-poweroff: Allow it to work on Raspberry Pi See: raspberrypi/linux#1031 kernel: BCM270X_DT: Create a core clock, use it for SPI and sdhost kernel: BCM270X_DT: Add overlay to enable uart1 See: raspberrypi/linux#1008 kernel: config: Enable ZSMALLOC, ZRAM and PGTABLE_MAPPING See: Hexxeh/rpi-firmware#85 firmware: arm_loader: Support initialising vchiq through mailbox property interface See: raspberrypi/linux#1026 firmware: drivers/usb: Reduce busy-wait to sensible timeout See: raspberrypi/linux#1026 firmware: video_encode: Initialise headers for video_bitrate See: raspberrypi#163 firmware: arm_loader: Use the new core_freq DT parameter if present firmware: arm_loader: Set the uart1_clkrate DT property from core_freq firmware: arm_cursor: Better handling of a second app requesting a cursor firmware: arm: Tidy up setting of arm_control and arm_bash
Can this be closed as fixed? |
@6by9 This appears to be fixed? |
AFAIK It's fixed. Confirmation would have been nice from the OP, but may as well close after all this time. |
OMX_VIDEO_PARAM_BITRATETYPE bitrate_param;
GST_OMX_INIT_STRUCT (&bitrate_param); // set up to init values
bitrate_param.nPortIndex = self->enc_out_port->index;
OMX_ERRORTYPE err;
err = OMX_GetParameter (self->enc->handle, OMX_IndexParamVideoBitrate, &bitrate_param);
OMX_GetParameter return zero in version, size, port
It should return same port I setup up before OMX_GetParameter
right version and size
some frameworks like gst-omx use get/set mechanism for initialization
The text was updated successfully, but these errors were encountered: