Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI hardware (MFRC522) not working with Latest Jessie release (2016-05-10-raspbian-jessie) #1547

Closed
cscuilla opened this issue Jun 28, 2016 · 189 comments

Comments

@cscuilla
Copy link

The rfid reader (MFRC522) does not work with the latest release of Jessie(2016-05-10). It works fine on the previous version (2016-03-18). I believe this is due to the new version of SPI.

On previous Jessie version (2016-03-18-raspbian-jessie) if I type lsmod after installing spi I get the following..
spi_bcm2708

On recent Jessie version (2016-05-10-raspbian-jessie) if I type lsmod after installing spi I get the following..
spi_bcm2835

Others, are having the same issue as described on the raspberry pi forum at this link..
https://www.raspberrypi.org/forums/viewtopic.php?f=107&t=148890

@pelwell
Copy link
Contributor

pelwell commented Jun 28, 2016

Can you describe the configuration of your system - any relevant entries in config.txt, cmdline,txt, /etc/modules or /etc/modprobe.d/*.conf?

Also, can you explain the failure mode - what do you expect to happen, and what actually happens?

@cscuilla
Copy link
Author

To get it working on previous Jessie Release (2016-03-18) I have to add the following to /boot/config.txt

device_tree_param=spi=on
dtoverlay=spi-bcm2708
This does NOT work on latest Jessie release. I've also tried
dtoverlay=spi-bcm7835

The failure mode is as follows.. Once I run the script it appears to work as it is waiting for a card to be scanned, however when I scan a card, nothing is output.

On previous Jessie(where card reader works), when I run the script and scan a card, the UID of the card is printed.

@pelwell
Copy link
Contributor

pelwell commented Jun 28, 2016

Can you confirm that with just dtparam=spi=on in config.txt (by which I mean no other spi-related settings) and spi-dev in /etc/modules that /dev/spi0.0 and /dev/spi0.1 appear but your script fails?

@pelwell
Copy link
Contributor

pelwell commented Jun 28, 2016

I've just ordered one of these devices, but it probably won't arrive before next week and I can't promise much time to look at this.

@cscuilla
Copy link
Author

what do you mean by this part

and spi-dev in /etc/modules that /dev/spi0.0 and /dev/spi0.1 appear but your script fails?
Currently, if I open /etc/modules all I have is
i2c-dev

@pelwell
Copy link
Contributor

pelwell commented Jun 28, 2016

Sorry, that's correct. SPI and I2C are strangely different in that respect the layered, user-space interface to I2C (i2c-dev) isn't loaded by Device Tree because it isn't hardware-specific, but the equivalent module for SPI (spidev) is.

So, to be more accurate: can you confirm that with just dtparam=spi=on in config.txt (by which I mean no other spi-related settings) that /dev/spi0.0 and /dev/spi0.1 appear but your script fails?

@cscuilla
Copy link
Author

OK, thanks, I am setting up a new memory card now with the latest release so I can confirm this for you.

@cscuilla
Copy link
Author

I can confirm this.. In /boot/config.txt I have the following

dtparam=spi=on

If I go into the /dev folder and type "ls"
I see spidev0.0 and spidev0.1

When I start my script, I receive no output once I scan a card.

@cscuilla
Copy link
Author

Thank you for ordering the hardware. I understand your time is limited but do appreciate the help. Here are the full steps to get the reader working on previous debian OS in case it helps you to troubleshoot..

  1. add to the bottom of /boot/config.txt
    • device_tree_param=spi=on
    • dtoverlay=spi-bcm2708
  2. Install python-dev
    • sudo apt-get install python-dev
  3. Install SPI
  4. Install Sample RFID Reader python library and sample script.
  5. Run sample script.
    • sudo python ~/MFRC522-python/read.py

@EECSdude
Copy link

I am running Raspberry Pi 2 B on Linux 4.4.11-v7+ #888 SMP Mon May 23 20:10:33 BST 2016 armv7l GNU/Linux with exact same behavior. I am online the next hour and happy to run any tests, provide any files.

Scope traces show the following.
GPIO 25, the RST line is always high, I don’t see it move.
GPIO 8 is always low, I don’t see it move, although I do see digital noise similar to SCLK at the millivolt level.
SCLK toggles the whole time Read.py is running, as expected.
As an experiment, I rebooted then ran a few commands to toggle GPIO25 up and down to check my scope setup. When I ran the same script with 25 set to 8, I got a runtime warning in response to GPIO.setup(8, GPIO.OUT) “this channel is already in use”.

I would expect to get that message if the GPIO was in CE0 mode, not a GPIO output as gpio readall says it is.

@pelwell
Copy link
Contributor

pelwell commented Jun 28, 2016

You say that GPIO 25 is the reset line, but the code appears to use GPIO 22 - is this a non-standard numbering issue, or have you modified your version of the code?

As mentioned in the Forum thread, the spi-bcm2835 driver uses software-controlled CE lines rather than ones driven by the hardware block, to work around a hardware glitch, which means that the driver is claiming the pin for GPIO - this explains the contention.

I see there is an spidev Python module that uses the spidev interface - does the spi module also do this, or is it a pure user-space software implementation?

@EECSdude
Copy link

I have not modifed Read.py. Interesting, I'll move the wire and see what happens.

https://github.com/mxgxw/MFRC522-python shows:

Name Pin # Pin name
SDA 24 GPIO8
SCK 23 GPIO11
MOSI 19 GPIO10
MISO 21 GPIO9
IRQ None None
GND Any Any Ground
RST 22 GPIO25
3.3V 1 3V3

@pelwell
Copy link
Contributor

pelwell commented Jun 28, 2016

I can answer the second question myself now - the SPI-Py (spi) module drives the spidev interface from C code.

@EECSdude
Copy link

PIN 22 is GPIO25, what pin configuration is the code using? Moving the wire now.

@cscuilla
Copy link
Author

For me, The python script uses "board" as the mode for rip.gpio. So the reset is on pin 22 but GPIO number 25.

I'm not sure what u mean in regards to the spidev Python module.

@EECSdude
Copy link

Moving the RFID modules RST pin from Raspberry Pi pin 22 / GPIO25 to pin 15/GPIO 22 doesn't make it work.

@pelwell
Copy link
Contributor

pelwell commented Jun 28, 2016

OK - I see that RPi.GPIO is configured in BOARD mode, so 22 is the header pin number but it carries GPIO 25, so that isn't the problem.

@EECSdude
Copy link

EECSdude commented Jun 28, 2016

LONG - Here's all the pertinent information in my system that has been asked for in the thread above:

I did one more thing than the previous post, suggested by a website I have forgotten:

Install latest version of bcm2835, C library for Broadcom BCM 2835 as used in Raspberry Pi; version 1.46 currently.
(http://www.airspayce.com/mikem/bcm2835/)

# download the latest version of the library, say bcm2835-1.xx.tar.gz, then:
$ tar zxvf bcm2835-1.xx.tar.gz
$ cd bcm2835-1.xx
$ ./configure
$ make
$ sudo make check
$ sudo make install

The above didn’t cause MFRC522-python\Read.py to work

It felt like the problem is a conflict between 2835 and 2708, so I have added and commented out things with no success and no error indication.

Here's a snapshot of a system that runs Read.py with no error and no card read:

$ ls /dev/spi*
/dev/spidev0.0  /dev/spidev0.1
$ lsmod
Module                  Size  Used by
xt_multiport            1756  1
iptable_filter          1409  1
ip_tables              11637  1 iptable_filter
x_tables               12507  3 ip_tables,xt_multiport,iptable_filter
cfg80211              427855  0
rfkill                 16037  1 cfg80211
evdev                  11396  4
bcm2835_wdt             3225  0
bcm2835_gpiomem         3040  0
uio_pdrv_genirq         3164  0
uio                     8000  1 uio_pdrv_genirq
spi_bcm2835             7286  0
snd_bcm2835            20511  0
snd_pcm                75698  1 snd_bcm2835
snd_timer              19160  1 snd_pcm
snd                    51844  3 snd_bcm2835,snd_timer,snd_pcm
i2c_bcm2708             4770  0
i2c_dev                 5859  0
fuse                   83461  1
ipv6                  347530  45
$ cat /boot/config.txt (clipped only bottom)
# Uncomment some or all of these to enable the optional hardware interfaces
#dtparam=i2c_arm=on
#dtparam=i2s=on
dtparam=spi=on
# Uncomment this to enable the lirc-rpi module
#dtoverlay=lirc-rpi

# Additional overlays and parameters are documented /boot/overlays/README

# Enable audio (loads snd_bcm2835)
dtparam=audio=on
dtparam=spi=on
dtparam=i2c_arm=on
start_x=1
gpu_mem=128

dtoverlay=spi-bcm2835

#dtoverlay=spi-bcm2708
$ cat /etc/modules
# /etc/modules: kernel modules to load at boot time.
#
# This file contains the names of kernel modules that should be loaded
# at boot time, one per line. Lines beginning with "#" are ignored.

i2c-dev
i2c-bcm2708
snd-bcm2835
#i2c-bcm2835
#rtc-ds1307
#spi-dev
spi-bcm2835
#spi-bcm2708

The files “etc/modprobe.d/*.conf” are only empty blacklist files.

@pelwell
Copy link
Contributor

pelwell commented Jun 28, 2016

Thanks for all of that information. A few comments:

  1. Don't use dtoverlay=spi-bcm2835 - that overlay isn't needed and doesn't exist anymore.
  2. You don't need to load i2c-bcm2708, snd-bcm2835 or spi-bcm2835 - they are all loaded by Device Tree nowadays.

I don't think either of these will cause your problem, I'm just trying to encourage best practises.

@EECSdude
Copy link

Just noticed the original post and I are using different libraries with same result.
Original post is: https://github.com/rasplay/MFRC522-python
I'm using: https://github.com/mxgxw/MFRC522-python.

Both are 2 years since last update.
Both use SPI-Py. Common failure point?

@EECSdude
Copy link

Thank you pelwell, followed best practices and still no joy, but I feel so much cleaner! Just FYI, I have moved this particular RFID hardware to an Arduino and it works.

@pelwell
Copy link
Contributor

pelwell commented Jun 29, 2016

There was an issue around the time of the Pi2 launch caused by a change to the SPI ioctl interface - a field in a structure that was an output became an input and output, and many libraries had to be changed to zero that field before calling the ioctl in question. I'll find the details later.

@EECSdude
Copy link

Anything like this: http://stackoverflow.com/questions/10828194/issue-with-spi-serial-port-comm-stuck-on-ioctl

or this:

http://www.raspberry-projects.com/pi/programming-in-c/spi/using-the-spi-interface

Issues:
"Error – Problem transmitting spi data..ioctl: Invalid argument

Due to changes in the underlying library the spi_ioc_transfer struct now needs to be initialised to NULL, and a hacky fix is to add this to the beginning of the for loop (this has been done in the code example above)

memset(&spi[i], 0, sizeof (spi[i]));

@pelwell
Copy link
Contributor

pelwell commented Jun 29, 2016

That second link is the issue I was referring to. You could try adding this to spi.c in the SPI-Py library at line 190:

                .cs_change = 1,
+               .pad = 0,
    };

A more future-proof fix would be to memset the structure to zero before setting the required fields, but that would need a bit more restructuring.

If a non-zero pad field is the cause of the problem then I'm slightly surprised that you don't see the "can't send spi message" error message.

@cscuilla
Copy link
Author

I tried adding the change to spi.c, but the issue is the same. No error message when running script, but no output when trying to read a card.

@EECSdude
Copy link

Any more help I can provide? We have some great momentum on this.

@pelwell
Copy link
Contributor

pelwell commented Jun 30, 2016

I won't do any more on this until the hardware arrives, which should be next week.

@Jbithell
Copy link

I'm having issues with this as well - I've had it working quite well for some time - a quick SD flash and new raspian install (as I change project) and nothing with SPI seems to be working.

I've tried everything I can think of, on 2 different Pi's (B+ and 3) - and nothing working on either of them. Currently resorting to banging my head against a wall

@Jbithell
Copy link

I'm going to try a rollback using http://downloads.raspberrypi.org/raspbian/images/

@pelwell
Copy link
Contributor

pelwell commented May 24, 2019

That's true - with the newer SPI-Py, the openSPI method returns a device handle that needs to be passed to the transfer method, so something like:

  def __init__(self,spd=1000000):
    self.dev = spi.openSPI(speed=spd,mode=0x40)
    GPIO.setmode(GPIO.BOARD)
...
  def Write_MFRC522(self,addr,val):
    spi.transfer(self.dev,((addr<<1)&0x7E,val))
  
  def Read_MFRC522(self,addr):
    val = spi.transfer(self.dev,(((addr<<1)&0x7E) | 0x80,0))
    return val[1]

@cscuilla
Copy link
Author

Thanks again @pelwell so to clarify, are you saying to make those changes to the MFRC522.py file and it should work with latest SpI-Py library?

@pelwell
Copy link
Contributor

pelwell commented May 24, 2019

Unless I've made a mistake (I haven't tested that patch), yes - that should fix it. It's a shame there wasn't a backwards-compatible way to make the SPI-Py changes.

@ksanchez15
Copy link

Thanks guys, but even with the old version of the library it still doesn't scan my card. @pelwell I followed your instructions (#2613) but right at step 1, I don't see options named SPI in Advanced Options (in raspi-config). Therefore, when I run dtoverlay -l I get No overlays loaded

@cscuilla
Copy link
Author

@pelwell thanks again i will test early next week.. @lesanchez try "Interface Options" under raspi-config. Enable SPI, then reboot and try again.

@ksanchez15
Copy link

@cscuilla I just did that but the command dtoverlay - l still returns the same thing. It should be noted that I do see the line dtparam=spi=on in my /boot/config.txt folder.
Also when I run lsmod | grep spi I get
spidev 20480
spi_bcm2835 20480 0

@ksanchez15
Copy link

@pelwell After your fix, I see get the following warning when I run Read.py:

/home/pi/MFRC522-python/MFRC522.py:133: RuntimeWarning: This channel is already in use, continuing anyway. Use GPIO.setwarnings(False) to disable warnings.

@pelwell
Copy link
Contributor

pelwell commented May 24, 2019

dtoverlay -l will only list overlays (and DT parameters) applied by Linux at run time. Overlays applied by the firmware become part of the base DTB, so Linux isn't aware that is what they are.

@cscuilla
Copy link
Author

@lesanchez It's probably your wiring or soldering that is the problem then.

@ksanchez15
Copy link

@cscuilla @pelwell all right thank you guys

@pelwell
Copy link
Contributor

pelwell commented May 24, 2019

That warning is because GPIO 25 (pin 22) has been left as an output by a previous failed run. Run raspi-gpio set 25 ip and try again. Once the script is working, provided you exit cleanly with Ctrl-C you shouldn't see that warning.

@ksanchez15
Copy link

I have quadruple check my wiring (even asked a colleague who is an electrical engineer) and everything is good. I have checked out the old version of SPI-Py and I'm using https://github.com/mxgxw/MFRC522-python's latest version.
Still, the tag (which was sent with the RC522 board) doesn't trigger anything. Could the issue come from somewhere else?

@ksanchez15
Copy link

ksanchez15 commented May 27, 2019

@pelwell I tried to run this and I get this output

00: 00 82 84 86 88 8a 8c 8e
08: 90 92 94 96 98 9a 9c 9e
10: a0 a2 a4 a6 a8 aa ac ae
18: b0 b2 b4 b6 b8 ba bc be
20: c0 c2 c4 c6 c8 ca cc ce
28: d0 d2 d4 d6 d8 da dc de
30: e0 e2 e4 e6 e8 ea ec ee
38: f0 f2 f4 f6 f8 fa fc fe

which tells me that, at least, the spi part of the equation is working properly. Also, every time I run the script, the values change entirely.

@pelwell
Copy link
Contributor

pelwell commented May 27, 2019

The values the test app is reading back are the same as those it is sending. (If you are curious, you could try deliberately connecting MOSI to MISO to see what the results are.)

Is the CS line connected correctly? And is the device powered. As part of the diagnostic process you can disconnect each pin, one at a time (but not GND) and observe the changes in the output.

TiejunChina pushed a commit that referenced this issue Jun 19, 2019
Select software CS in bcm2708_common.dtsi, and disable the automatic
conversion in the driver to allow hardware CS to be re-enabled with an
overlay.

See: #1547

Signed-off-by: Phil Elwell <[email protected]>
TiejunChina pushed a commit that referenced this issue Jul 23, 2019
Select software CS in bcm2708_common.dtsi, and disable the automatic
conversion in the driver to allow hardware CS to be re-enabled with an
overlay.

See: #1547

Signed-off-by: Phil Elwell <[email protected]>
@cscuilla
Copy link
Author

That's true - with the newer SPI-Py, the openSPI method returns a device handle that needs to be passed to the transfer method, so something like:

  def __init__(self,spd=1000000):
    self.dev = spi.openSPI(speed=spd,mode=0x40)
    GPIO.setmode(GPIO.BOARD)
...
  def Write_MFRC522(self,addr,val):
    spi.transfer(self.dev,((addr<<1)&0x7E,val))
  
  def Read_MFRC522(self,addr):
    val = spi.transfer(self.dev,(((addr<<1)&0x7E) | 0x80,0))
    return val[1]

@pelwell i can confirm your patch works with latest spi library! thanks again.

mseaster-wr pushed a commit to WindRiver-Labs/yocto-kernel-cache that referenced this issue Aug 5, 2019
Issue: LINUXPG-25

1/198 [
Author: Steve Glendinning
Email: [email protected]
Subject: smsx95xx: fix crimes against truesize
Date: Thu, 19 Feb 2015 18:47:12 +0000

commit 9cab2037b31cf4b4f69c9da9f364650c74aec1e5 from
https://github.com/raspberrypi/linux.git

smsc95xx is adjusting truesize when it shouldn't, and following a recent patch from Eric this is now triggering warnings.

This patch stops smsc95xx from changing truesize.

Signed-off-by: Steve Glendinning <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

2/198 [
Author: Sam Nazarko
Email: [email protected]
Subject: smsc95xx: Experimental: Enable turbo_mode and packetsize=2560 by default
Date: Fri, 1 Apr 2016 17:27:21 +0100

commit 4773e045e6047fa895c0cd6e5e2b97ac76413227 from
https://github.com/raspberrypi/linux.git

See: http://forum.kodi.tv/showthread.php?tid=285288
Signed-off-by: Xulin Sun <[email protected]>
]

3/198 [
Author: popcornmix
Email: [email protected]
Subject: Allow mac address to be set in smsc95xx
Date: Tue, 26 Mar 2013 17:26:38 +0000

commit a2af0e77a9eb348e5e06a886882d37cb73f63196 from
https://github.com/raspberrypi/linux.git

Signed-off-by: popcornmix <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

4/198 [
Author: Phil Elwell
Email: [email protected]
Subject: irq-bcm2836: Prevent spurious interrupts, and trap them early
Date: Fri, 4 Dec 2015 17:41:50 +0000

commit 8deb5f0d9bc9e27aa42846924cbe1839f066c572 from
https://github.com/raspberrypi/linux.git

The old arch-specific IRQ macros included a dsb to ensure the
write to clear the mailbox interrupt completed before returning
from the interrupt. The BCM2836 irqchip driver needs the same
precaution to avoid spurious interrupts.

Spurious interrupts are still possible for other reasons,
though, so trap them early.
Signed-off-by: Xulin Sun <[email protected]>
]

5/198 [
Author: Phil Elwell
Email: [email protected]
Subject: irq-bcm2836: Avoid "Invalid trigger warning"
Date: Thu, 9 Feb 2017 14:33:30 +0000

commit 0dfd5ac76e7cb9e0d3a2317b3c0cbffe452469ee from
https://github.com/raspberrypi/linux.git

Initialise the level for each IRQ to avoid a warning from the
arm arch timer code.

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

6/198 [
Author: Noralf Trønnes
Email: [email protected]
Subject: irqchip: bcm2835: Add FIQ support
Date: Fri, 12 Jun 2015 19:01:05 +0200

commit 6e436b268ca71c0b0df49274b7038d62d040b402 from
https://github.com/raspberrypi/linux.git

Add a duplicate irq range with an offset on the hwirq's so the
driver can detect that enable_fiq() is used.
Tested with downstream dwc_otg USB controller driver.

Signed-off-by: Noralf Trønnes <[email protected]>
Reviewed-by: Eric Anholt <[email protected]>
Acked-by: Stephen Warren <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

7/198 [
Author: Noralf Trønnes
Email: [email protected]
Subject: irqchip: irq-bcm2835: Add 2836 FIQ support
Date: Fri, 23 Oct 2015 16:26:55 +0200

commit cfe3b818537b8e7f79e3f26315d757ffcb9fc496 from
https://github.com/raspberrypi/linux.git

Signed-off-by: Noralf Trønnes <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

8/198 [
Author: Phil Elwell
Email: [email protected]
Subject: spidev: Add "spidev" compatible string to silence warning
Date: Tue, 14 Jul 2015 10:26:09 +0100

commit 5353bfdc791a51a472f747fee67859f20879fcba from
https://github.com/raspberrypi/linux.git

See: https://github.com/raspberrypi/linux/issues/1054
Signed-off-by: Xulin Sun <[email protected]>
]

9/198 [
Author: Phil Elwell
Email: [email protected]
Subject: spi-bcm2835: Support pin groups other than 7-11
Date: Wed, 24 Jun 2015 14:10:44 +0100

commit ea7ff6bd869087be46f2d8f8ac59e85866fac12e from
https://github.com/raspberrypi/linux.git

The spi-bcm2835 driver automatically uses GPIO chip-selects due to
some unreliability of the native ones. In doing so it chooses the
same pins as the native chip-selects would use, but the existing
code always uses pins 7 and 8, wherever the SPI function is mapped.

Search the pinctrl group assigned to the driver for pins that
correspond to native chip-selects, and use those for GPIO chip-
selects.

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

10/198 [
Author: Phil Elwell
Email: [email protected]
Subject: spi-bcm2835: Disable forced software CS
Date: Fri, 1 Jul 2016 22:09:24 +0100

commit 04313c2a5fe850e7cf3ba246dad6a9b7448c626b from
https://github.com/raspberrypi/linux.git

Select software CS in bcm2708_common.dtsi, and disable the automatic
conversion in the driver to allow hardware CS to be re-enabled with an
overlay.

See: https://github.com/raspberrypi/linux/issues/1547

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

11/198 [
Author: Phil Elwell
Email: [email protected]
Subject: spi-bcm2835: Remove unused code
Date: Tue, 8 Nov 2016 21:35:38 +0000

commit f3b81ae47cdd94ec311837c1be98dc7458c2b210 from
https://github.com/raspberrypi/linux.git

Signed-off-by: Xulin Sun <[email protected]>
]

12/198 [
Author: Noralf Trønnes
Email: [email protected]
Subject: dmaengine: bcm2835: Load driver early and support legacy API
Date: Sat, 3 Oct 2015 22:22:55 +0200

commit 396b1ca5e76a360b08770ebd3c8ffb5c628f9311 from
https://github.com/raspberrypi/linux.git

Load driver early since at least bcm2708_fb doesn't support deferred
probing and even if it did, we don't want the video driver deferred.
Support the legacy DMA API which is needed by bcm2708_fb.
Don't mask out channel 2.

Signed-off-by: Noralf Trønnes <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

13/198 [
Author: popcornmix
Email: [email protected]
Subject: firmware: Updated mailbox header
Date: Mon, 25 Jan 2016 17:25:12 +0000

commit fd2e06b09ff06d7903bb170de557b14b94e32fc3 from
https://github.com/raspberrypi/linux.git

Signed-off-by: Xulin Sun <[email protected]>
]

14/198 [
Author: Phil Elwell
Email: [email protected]
Subject: rtc: Add SPI alias for pcf2123 driver
Date: Wed, 15 Jun 2016 16:48:41 +0100

commit de184f31fea6c23260c44e8494822baeda84351f from
https://github.com/raspberrypi/linux.git

Without this alias, Device Tree won't cause the driver
to be loaded.

See: https://github.com/raspberrypi/linux/pull/1510
Signed-off-by: Xulin Sun <[email protected]>
]

15/198 [
Author: Noralf Trønnes
Email: [email protected]
Subject: watchdog: bcm2835: Support setting reboot partition
Date: Fri, 7 Oct 2016 16:50:59 +0200

commit 3bb6ebcaad1cbbbb6e9540d4ddce76540aa26ac6 from
https://github.com/raspberrypi/linux.git

The Raspberry Pi firmware looks at the RSTS register to know which
partition to boot from. The reboot syscall command
LINUX_REBOOT_CMD_RESTART2 supports passing in a string argument.

Add support for passing in a partition number 0..63 to boot from.
Partition 63 is a special partiton indicating halt.
If the partition doesn't exist, the firmware falls back to partition 0.

Signed-off-by: Noralf Trønnes <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

16/198 [
Author: popcornmix
Email: [email protected]
Subject: bcm: Make RASPBERRYPI_POWER depend on PM
Date: Wed, 9 Nov 2016 13:02:52 +0000

commit b8f1a65be7d9b6b3ed833f3709334a8af89f7605 from
https://github.com/raspberrypi/linux.git

Signed-off-by: Xulin Sun <[email protected]>
]

17/198 [
Author: Martin Sperl
Email: [email protected]
Subject: Register the clocks early during the boot process, so that special/critical clocks can get enabled early on in the boot process avoiding the risk of disabling a clock, pll_divider or pll when a claiming driver fails to install propperly - maybe it needs to defer.
Date: Fri, 2 Sep 2016 16:45:27 +0100

commit eb41f40ad817710b057d1992d3456c0833fb22c2 from
https://github.com/raspberrypi/linux.git

Signed-off-by: Martin Sperl <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

18/198 [
Author: popcornmix
Email: [email protected]
Subject: bcm2835-rng: Avoid initialising if already enabled
Date: Tue, 6 Dec 2016 17:05:39 +0000

commit 05b3a8563564238804a46108eace0e51036b5d44 from
https://github.com/raspberrypi/linux.git

Avoids the 0x40000 cycles of warmup again if firmware has already used it
Signed-off-by: Xulin Sun <[email protected]>
]

19/198 [
Author: Phil Elwell
Email: [email protected]
Subject: clk-bcm2835: Mark used PLLs and dividers CRITICAL
Date: Mon, 13 Feb 2017 17:20:08 +0000

commit 353ead3947248a683c7ab3013bd5d27ec5ca900c from
https://github.com/raspberrypi/linux.git

The VPU configures and relies on several PLLs and dividers. Mark all
enabled dividers and their PLLs as CRITICAL to prevent the kernel from
switching them off.

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

20/198 [
Author: Phil Elwell
Email: [email protected]
Subject: clk-bcm2835: Add claim-clocks property
Date: Mon, 13 Feb 2017 17:20:08 +0000

commit 405680f60cf3685841e6c814297daaee85f9e5b0 from
https://github.com/raspberrypi/linux.git

The claim-clocks property can be used to prevent PLLs and dividers
from being marked as critical. It contains a vector of clock IDs,
as defined by dt-bindings/clock/bcm2835.h.

Use this mechanism to claim PLLD_DSI0, PLLD_DSI1, PLLH_AUX and
PLLH_PIX for the vc4_kms_v3d driver.

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

21/198 [
Author: Phil Elwell
Email: [email protected]
Subject: clk-bcm2835: Read max core clock from firmware
Date: Mon, 6 Mar 2017 09:06:18 +0000

commit 56279302d8b1c5915f0aa366c94c0bd8c8596efa from
https://github.com/raspberrypi/linux.git

The VPU is responsible for managing the core clock, usually under
direction from the bcm2835-cpufreq driver but not via the clk-bcm2835
driver. Since the core frequency can change without warning, it is
safer to report the maximum clock rate to users of the core clock -
I2C, SPI and the mini UART - to err on the safe side when calculating
clock divisors.

If the DT node for the clock driver includes a reference to the
firmware node, use the firmware API to query the maximum core clock
instead of reading the divider registers.

Prior to this patch, a "100KHz" I2C bus was sometimes clocked at about
160KHz. In particular, switching to the 4.9 kernel was likely to break
SenseHAT usage on a Pi3.

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

22/198 [
Author: Eric Anholt
Email: [email protected]
Subject: clk: bcm2835: Mark GPIO clocks enabled at boot as critical.
Date: Mon, 9 May 2016 17:28:18 -0700

commit a7ec48448921416003f7361f4b148b98094fa075 from
https://github.com/raspberrypi/linux.git

These divide off of PLLD_PER and are used for the ethernet and wifi
PHYs source PLLs.  Neither of them is currently represented by a phy
device that would grab the clock for us.

This keeps other drivers from killing the networking PHYs when they
disable their own clocks and trigger PLLD_PER's refcount going to 0.

v2: Skip marking as critical if they aren't on at boot.

Signed-off-by: Eric Anholt <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

23/198 [
Author: Phil Elwell
Email: [email protected]
Subject: sound: Demote deferral errors to INFO level
Date: Thu, 9 Feb 2017 14:36:44 +0000

commit 4414cd5bd0b288b4d6ff56372a08c72ac41404e2 from
https://github.com/raspberrypi/linux.git

At present there is no mechanism to specify driver load order,
which can lead to deferrals and repeated retries until successful.
Since this situation is expected, reduce the dmesg level to
INFO and mention that the operation will be retried.

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

24/198 [
Author: Claggy3
Email: [email protected]
Subject: Update vfpmodule.c
Date: Sat, 11 Feb 2017 14:00:30 +0000

commit cbeb7728187c7abb598f6b3f58ffcebc94e960d3 from
https://github.com/raspberrypi/linux.git

Christopher Alexander Tobias Schulze - May 2, 2015, 11:57 a.m.
This patch fixes a problem with VFP state save and restore related
to exception handling (panic with message "BUG: unsupported FP
instruction in kernel mode") present on VFP11 floating point units
(as used with ARM1176JZF-S CPUs, e.g. on first generation Raspberry
Pi boards). This patch was developed and discussed on

   https://github.com/raspberrypi/linux/issues/859

A precondition to see the crashes is that floating point exception
traps are enabled. In this case, the VFP11 might determine that a FPU
operation needs to trap at a point in time when it is not possible to
signal this to the ARM11 core any more. The VFP11 will then set the
FPEXC.EX bit and store the trapped opcode in FPINST. (In some cases,
a second opcode might have been accepted by the VFP11 before the
exception was detected and could be reported to the ARM11 - in this
case, the VFP11 also sets FPEXC.FP2V and stores the second opcode in
FPINST2.)

If FPEXC.EX is set, the VFP11 will "bounce" the next FPU opcode issued
by the ARM11 CPU, which will be seen by the ARM11 as an undefined opcode
trap. The VFP support code examines the FPEXC.EX and FPEXC.FP2V bits
to decide what actions to take, i.e., whether to emulate the opcodes
found in FPINST and FPINST2, and whether to retry the bounced instruction.

If a user space application has left the VFP11 in this "pending trap"
state, the next FPU opcode issued to the VFP11 might actually be the
VSTMIA operation vfp_save_state() uses to store the FPU registers
to memory (in our test cases, when building the signal stack frame).
In this case, the kernel crashes as described above.

This patch fixes the problem by making sure that vfp_save_state() is
always entered with FPEXC.EX cleared. (The current value of FPEXC has
already been saved, so this does not corrupt the context. Clearing
FPEXC.EX has no effects on FPINST or FPINST2. Also note that many
callers already modify FPEXC by setting FPEXC.EN before invoking
vfp_save_state().)

This patch also addresses a second problem related to FPEXC.EX: After
returning from signal handling, the kernel reloads the VFP context
from the user mode stack. However, the current code explicitly clears
both FPEXC.EX and FPEXC.FP2V during reload. As VFP11 requires these
bits to be preserved, this patch disables clearing them for VFP
implementations belonging to architecture 1. There should be no
negative side effects: the user can set both bits by executing FPU
opcodes anyway, and while user code may now place arbitrary values
into FPINST and FPINST2 (e.g., non-VFP ARM opcodes) the VFP support
code knows which instructions can be emulated, and rejects other
opcodes with "unhandled bounce" messages, so there should be no
security impact from allowing reloading FPEXC.EX and FPEXC.FP2V.

Signed-off-by: Christopher Alexander Tobias Schulze <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

25/198 [
Author: Noralf Trønnes
Email: [email protected]
Subject: i2c: bcm2835: Add debug support
Date: Tue, 1 Nov 2016 15:15:41 +0100

commit fc162c9c462ff3a2c7fb523e75993dcf50dae277 from
https://github.com/raspberrypi/linux.git

This adds a debug module parameter to aid in debugging transfer issues
by printing info to the kernel log. When enabled, status values are
collected in the interrupt routine and msg info in
bcm2835_i2c_start_transfer(). This is done in a way that tries to avoid
affecting timing. Having printk in the isr can mask issues.

debug values (additive):
1: Print info on error
2: Print info on all transfers
3: Print messages before transfer is started

The value can be changed at runtime:
/sys/module/i2c_bcm2835/parameters/debug

Example output, debug=3:
[  747.114448] bcm2835_i2c_xfer: msg(1/2) write addr=0x54, len=2 flags= [i2c1]
[  747.114463] bcm2835_i2c_xfer: msg(2/2) read addr=0x54, len=32 flags= [i2c1]
[  747.117809] start_transfer: msg(1/2) write addr=0x54, len=2 flags= [i2c1]
[  747.117825] isr: remain=2, status=0x30000055 : TA TXW TXD TXE  [i2c1]
[  747.117839] start_transfer: msg(2/2) read addr=0x54, len=32 flags= [i2c1]
[  747.117849] isr: remain=32, status=0xd0000039 : TA RXR TXD RXD  [i2c1]
[  747.117861] isr: remain=20, status=0xd0000039 : TA RXR TXD RXD  [i2c1]
[  747.117870] isr: remain=8, status=0x32 : DONE TXD RXD  [i2c1]

Signed-off-by: Noralf Trønnes <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

26/198 [
Author: Phil Elwell
Email: [email protected]
Subject: ASoC: Add prompt for ICS43432 codec
Date: Thu, 23 Mar 2017 10:06:56 +0000

commit 0ae19a02310fd7eb5094b28384599ecb81bad9f0 from
https://github.com/raspberrypi/linux.git

Without a prompt string, a config setting can't be included in a
defconfig. Give CONFIG_SND_SOC_ICS43432 a prompt so that Pi soundcards
can use the driver.

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

27/198 [
Author: Phil Elwell
Email: [email protected]
Subject: irqchip: irq-bcm2836: Remove regmap and syscon use
Date: Tue, 23 Jan 2018 16:52:45 +0000

commit 71dce1629ab630dec52ce7af74741499957ed2e2 from
https://github.com/raspberrypi/linux.git

The syscon node defines a register range that duplicates that used by
the local_intc node on bcm2836/7. Since irq-bcm2835 and irq-bcm2836 are
built in and always present together (both drivers are enabled by
CONFIG_ARCH_BCM2835), it is possible to replace the syscon usage with a
global variable that simplifies the code. Doing so does lose the
locking provided by regmap, but as only one side is using the regmap
interface (irq-bcm2835 uses readl and write) there is no loss of
atomicity.

See: https://github.com/raspberrypi/firmware/issues/926

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

28/198 [
Author: Phil Elwell
Email: [email protected]
Subject: lan78xx: Enable LEDs and auto-negotiation
Date: Tue, 17 Oct 2017 15:04:29 +0100

commit bc54c0860814538372e8722997f81e03c326de70 from
https://github.com/raspberrypi/linux.git

For applications of the LAN78xx that don't have valid programmed
EEPROMs or OTPs, enabling both LEDs and auto-negotiation by default
seems reasonable.

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

29/198 [
Author: Phil Elwell
Email: [email protected]
Subject: amba_pl011: Don't use DT aliases for numbering
Date: Tue, 23 Feb 2016 17:26:48 +0000

commit 410b9b4c093723011b9f9029cd0a3263770c82a1 from
https://github.com/raspberrypi/linux.git

The pl011 driver looks for DT aliases of the form "serial<n>",
and if found uses <n> as the device ID. This can cause
/dev/ttyAMA0 to become /dev/ttyAMA1, which is confusing if the
other serial port is provided by the 8250 driver which doesn't
use the same logic.
Signed-off-by: Xulin Sun <[email protected]>
]

30/198 [
Author: Phil Elwell
Email: [email protected]
Subject: amba_pl011: Round input clock up
Date: Wed, 1 Mar 2017 16:07:39 +0000

commit 8229b667d625c3be22a5a276694980c92fdc1498 from
https://github.com/raspberrypi/linux.git

The UART clock is initialised to be as close to the requested
frequency as possible without exceeding it. Now that there is a
clock manager that returns the actual frequencies, an expected
48MHz clock is reported as 47999625. If the requested baudrate
== requested clock/16, there is no headroom and the slight
reduction in actual clock rate results in failure.

Detect cases where it looks like a "round" clock was chosen and
adjust the reported clock to match that "round" value. As the
code comment says:

/*
 * If increasing a clock by less than 0.1% changes it
 * from ..999.. to ..000.., round up.
 */

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

31/198 [
Author: Phil Elwell
Email: [email protected]
Subject: amba_pl011: Insert mb() for correct FIFO handling
Date: Fri, 29 Sep 2017 10:32:19 +0100

commit 4553df56cd3ba1adc0d5028c4fe214c6513a3293 from
https://github.com/raspberrypi/linux.git

The pl011 register accessor functions use the _relaxed versions of the
standard readl() and writel() functions, meaning that there are no
automatic memory barriers. When polling a FIFO status register to check
for fullness, it is necessary to ensure that any outstanding writes have
completed; otherwise the flags are effectively stale, making it possible
that the next write is to a full FIFO.

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

32/198 [
Author: Phil Elwell
Email: [email protected]
Subject: amba_pl011: Add cts-event-workaround DT property
Date: Fri, 29 Sep 2017 10:32:19 +0100

commit 2e815e181a707d0e18613bed0b4581c854ac9d6f from
https://github.com/raspberrypi/linux.git

The BCM2835 PL011 implementation seems to have a bug that can lead to a
transmission lockup if CTS changes frequently. A workaround was added to
the driver with a vendor-specific flag to enable it, but this flag is
currently not set for ARM implementations.

Add a "cts-event-workaround" property to Pi DTBs and use the presence
of that property to force the flag to be enabled in the driver.

See: https://github.com/raspberrypi/linux/issues/1280

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

33/198 [
Author: notro
Email: [email protected]
Subject: pinctrl-bcm2835: Set base to 0 give expected gpio numbering
Date: Thu, 10 Jul 2014 13:59:47 +0200

commit e8642bc07253b7adb5afbfa6b9752586dbc92b72 from
https://github.com/raspberrypi/linux.git

Signed-off-by: Noralf Tronnes <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

34/198 [
Author: popcornmix
Email: [email protected]
Subject: Main bcm2708/bcm2709 linux port
Date: Sun, 12 May 2013 12:24:19 +0100

commit e2bd78d6ece96ce047479f9bd0c9050ff86eb7c7 from
https://github.com/raspberrypi/linux.git

Signed-off-by: popcornmix <[email protected]>
Signed-off-by: Noralf Trønnes <[email protected]>

bcm2709: Drop platform smp and timer init code

irq-bcm2836 handles this through these functions:
bcm2835_init_local_timer_frequency()
bcm2836_arm_irqchip_smp_init()

Signed-off-by: Noralf Trønnes <[email protected]>

bcm270x: Use watchdog for reboot/poweroff

The watchdog driver already has support for reboot/poweroff.
Make use of this and remove the code from the platform files.

Signed-off-by: Noralf Trønnes <[email protected]>

board_bcm2835: Remove coherent dma pool increase - API has gone
Signed-off-by: Xulin Sun <[email protected]>
]

35/198 [
Author: popcornmix
Email: [email protected]
Subject: Add dwc_otg driver
Date: Wed, 1 May 2013 19:46:17 +0100

commit 530dc54b7eae24873d68bb01e80f87d0343bdbe8 from
https://github.com/raspberrypi/linux.git

Signed-off-by: popcornmix <[email protected]>

usb: dwc: fix lockdep false positive

Signed-off-by: Kari Suvanto <[email protected]>

usb: dwc: fix inconsistent lock state

Signed-off-by: Kari Suvanto <[email protected]>

Add FIQ patch to dwc_otg driver. Enable with dwc_otg.fiq_fix_enable=1. Should give about 10% more ARM performance.
Thanks to Gordon and Costas

Avoid dynamic memory allocation for channel lock in USB driver. Thanks ddv2005.

Add NAK holdoff scheme. Enabled by default, disable with dwc_otg.nak_holdoff_enable=0. Thanks gsh

Make sure we wait for the reset to finish

dwc_otg: fix bug in dwc_otg_hcd.c resulting in silent kernel
	 memory corruption, escalating to OOPS under high USB load.

dwc_otg: Fix unsafe access of QTD during URB enqueue

In dwc_otg_hcd_urb_enqueue during qtd creation, it was possible that the
transaction could complete almost immediately after the qtd was assigned
to a host channel during URB enqueue, which meant the qtd pointer was no
longer valid having been completed and removed. Usually, this resulted in
an OOPS during URB submission. By predetermining whether transactions
need to be queued or not, this unsafe pointer access is avoided.

This bug was only evident on the Pi model A where a device was attached
that had no periodic endpoints (e.g. USB pendrive or some wlan devices).

dwc_otg: Fix incorrect URB allocation error handling

If the memory allocation for a dwc_otg_urb failed, the kernel would OOPS
because for some reason a member of the *unallocated* struct was set to
zero. Error handling changed to fail correctly.

dwc_otg: fix potential use-after-free case in interrupt handler

If a transaction had previously aborted, certain interrupts are
enabled to track error counts and reset where necessary. On IN
endpoints the host generates an ACK interrupt near-simultaneously
with completion of transfer. In the case where this transfer had
previously had an error, this results in a use-after-free on
the QTD memory space with a 1-byte length being overwritten to
0x00.

dwc_otg: add handling of SPLIT transaction data toggle errors

Previously a data toggle error on packets from a USB1.1 device behind
a TT would result in the Pi locking up as the driver never handled
the associated interrupt. Patch adds basic retry mechanism and
interrupt acknowledgement to cater for either a chance toggle error or
for devices that have a broken initial toggle state (FT8U232/FT232BM).

dwc_otg: implement tasklet for returning URBs to usbcore hcd layer

The dwc_otg driver interrupt handler for transfer completion will spend
a very long time with interrupts disabled when a URB is completed -
this is because usb_hcd_giveback_urb is called from within the handler
which for a USB device driver with complicated processing (e.g. webcam)
will take an exorbitant amount of time to complete. This results in
missed completion interrupts for other USB packets which lead to them
being dropped due to microframe overruns.

This patch splits returning the URB to the usb hcd layer into a
high-priority tasklet. This will have most benefit for isochronous IN
transfers but will also have incidental benefit where multiple periodic
devices are active at once.

dwc_otg: fix NAK holdoff and allow on split transactions only

This corrects a bug where if a single active non-periodic endpoint
had at least one transaction in its qh, on frnum == MAX_FRNUM the qh
would get skipped and never get queued again. This would result in
a silent device until error detection (automatic or otherwise) would
either reset the device or flush and requeue the URBs.

Additionally the NAK holdoff was enabled for all transactions - this
would potentially stall a HS endpoint for 1ms if a previous error state
enabled this interrupt and the next response was a NAK. Fix so that
only split transactions get held off.

dwc_otg: Call usb_hcd_unlink_urb_from_ep with lock held in completion handler

usb_hcd_unlink_urb_from_ep must be called with the HCD lock held.  Calling it
asynchronously in the tasklet was not safe (regression in
c4564d4a1a0a9b10d4419e48239f5d99e88d2667).

This change unlinks it from the endpoint prior to queueing it for handling in
the tasklet, and also adds a check to ensure the urb is OK to be unlinked
before doing so.

NULL pointer dereference kernel oopses had been observed in usb_hcd_giveback_urb
when a USB device was unplugged/replugged during data transfer.  This effect
was reproduced using automated USB port power control, hundreds of replug
events were performed during active transfers to confirm that the problem was
eliminated.

USB fix using a FIQ to implement split transactions

This commit adds a FIQ implementaion that schedules
the split transactions using a FIQ so we don't get
held off by the interrupt latency of Linux

dwc_otg: fix device attributes and avoid kernel warnings on boot

dcw_otg: avoid logging function that can cause panics

See: https://github.com/raspberrypi/firmware/issues/21
Thanks to cleverca22 for fix

dwc_otg: mask correct interrupts after transaction error recovery

The dwc_otg driver will unmask certain interrupts on a transaction
that previously halted in the error state in order to reset the
QTD error count. The various fine-grained interrupt handlers do not
consider that other interrupts besides themselves were unmasked.

By disabling the two other interrupts only ever enabled in DMA mode
for this purpose, we can avoid unnecessary function calls in the
IRQ handler. This will also prevent an unneccesary FIQ interrupt
from being generated if the FIQ is enabled.

dwc_otg: fiq: prevent FIQ thrash and incorrect state passing to IRQ

In the case of a transaction to a device that had previously aborted
due to an error, several interrupts are enabled to reset the error
count when a device responds. This has the side-effect of making the
FIQ thrash because the hardware will generate multiple instances of
a NAK on an IN bulk/interrupt endpoint and multiple instances of ACK
on an OUT bulk/interrupt endpoint. Make the FIQ mask and clear the
associated interrupts.

Additionally, on non-split transactions make sure that only unmasked
interrupts are cleared. This caused a hard-to-trigger but serious
race condition when you had the combination of an endpoint awaiting
error recovery and a transaction completed on an endpoint - due to
the sequencing and timing of interrupts generated by the dwc_otg core,
it was possible to confuse the IRQ handler.

Fix function tracing

dwc_otg: whitespace cleanup in dwc_otg_urb_enqueue

dwc_otg: prevent OOPSes during device disconnects

The dwc_otg_urb_enqueue function is thread-unsafe. In particular the
access of urb->hcpriv, usb_hcd_link_urb_to_ep, dwc_otg_urb->qtd and
friends does not occur within a critical section and so if a device
was unplugged during activity there was a high chance that the
usbcore hub_thread would try to disable the endpoint with partially-
formed entries in the URB queue. This would result in BUG() or null
pointer dereferences.

Fix so that access of urb->hcpriv, enqueuing to the hardware and
adding to usbcore endpoint URB lists is contained within a single
critical section.

dwc_otg: prevent BUG() in TT allocation if hub address is > 16

A fixed-size array is used to track TT allocation. This was
previously set to 16 which caused a crash because
dwc_otg_hcd_allocate_port would read past the end of the array.

This was hit if a hub was plugged in which enumerated as addr > 16,
due to previous device resets or unplugs.

Also add #ifdef FIQ_DEBUG around hcd->hub_port_alloc[], which grows
to a large size if 128 hub addresses are supported. This field is
for debug only for tracking which frame an allocate happened in.

dwc_otg: make channel halts with unknown state less damaging

If the IRQ received a channel halt interrupt through the FIQ
with no other bits set, the IRQ would not release the host
channel and never complete the URB.

Add catchall handling to treat as a transaction error and retry.

dwc_otg: fiq_split: use TTs with more granularity

This fixes certain issues with split transaction scheduling.

- Isochronous multi-packet OUT transactions now hog the TT until
  they are completed - this prevents hubs aborting transactions
  if they get a periodic start-split out-of-order
- Don't perform TT allocation on non-periodic endpoints - this
  allows simultaneous use of the TT's bulk/control and periodic
  transaction buffers

This commit will mainly affect USB audio playback.

dwc_otg: fix potential sleep while atomic during urb enqueue

Fixes a regression introduced with eb1b482a. Kmalloc called from
dwc_otg_hcd_qtd_add / dwc_otg_hcd_qtd_create did not always have
the GPF_ATOMIC flag set. Force this flag when inside the larger
critical section.

dwc_otg: make fiq_split_enable imply fiq_fix_enable

Failing to set up the FIQ correctly would result in
"IRQ 32: nobody cared" errors in dmesg.

dwc_otg: prevent crashes on host port disconnects

Fix several issues resulting in crashes or inconsistent state
if a Model A root port was disconnected.

- Clean up queue heads properly in kill_urbs_in_qh_list by
  removing the empty QHs from the schedule lists
- Set the halt status properly to prevent IRQ handlers from
  using freed memory
- Add fiq_split related cleanup for saved registers
- Make microframe scheduling reclaim host channels if
  active during a disconnect
- Abort URBs with -ESHUTDOWN status response, informing
  device drivers so they respond in a more correct fashion
  and don't try to resubmit URBs
- Prevent IRQ handlers from attempting to handle channel
  interrupts if the associated URB was dequeued (and the
  driver state was cleared)

dwc_otg: prevent leaking URBs during enqueue

A dwc_otg_urb would get leaked if the HCD enqueue function
failed for any reason. Free the URB at the appropriate points.

dwc_otg: Enable NAK holdoff for control split transactions

Certain low-speed devices take a very long time to complete a
data or status stage of a control transaction, producing NAK
responses until they complete internal processing - the USB2.0
spec limit is up to 500mS. This causes the same type of interrupt
storm as seen with USB-serial dongles prior to c8edb238.

In certain circumstances, usually while booting, this interrupt
storm could cause SD card timeouts.

dwc_otg: Fix for occasional lockup on boot when doing a USB reset

dwc_otg: Don't issue traffic to LS devices in FS mode

Issuing low-speed packets when the root port is in full-speed mode
causes the root port to stop responding. Explicitly fail when
enqueuing URBs to a LS endpoint on a FS bus.

Fix ARM architecture issue with local_irq_restore()

If local_fiq_enable() is called before a local_irq_restore(flags) where
the flags variable has the F bit set, the FIQ will be erroneously disabled.

Fixup arch_local_irq_restore to avoid trampling the F bit in CPSR.

Also fix some of the hacks previously implemented for previous dwc_otg
incarnations.

dwc_otg: fiq_fsm: Base commit for driver rewrite

This commit removes the previous FIQ fixes entirely and adds fiq_fsm.

This rewrite features much more complete support for split transactions
and takes into account several OTG hardware bugs. High-speed
isochronous transactions are also capable of being performed by fiq_fsm.

All driver options have been removed and replaced with:
  - dwc_otg.fiq_enable (bool)
  - dwc_otg.fiq_fsm_enable (bool)
  - dwc_otg.fiq_fsm_mask (bitmask)
  - dwc_otg.nak_holdoff (unsigned int)

Defaults are specified such that fiq_fsm behaves similarly to the
previously implemented FIQ fixes.

fiq_fsm: Push error recovery into the FIQ when fiq_fsm is used

If the transfer associated with a QTD failed due to a bus error, the HCD
would retry the transfer up to 3 times (implementing the USB2.0
three-strikes retry in software).

Due to the masking mechanism used by fiq_fsm, it is only possible to pass
a single interrupt through to the HCD per-transfer.

In this instance host channels would fall off the radar because the error
reset would function, but the subsequent channel halt would be lost.

Push the error count reset into the FIQ handler.

fiq_fsm: Implement timeout mechanism

For full-speed endpoints with a large packet size, interrupt latency
runs the risk of the FIQ starting a transaction too late in a full-speed
frame. If the device is still transmitting data when EOF2 for the
downstream frame occurs, the hub will disable the port. This change is
not reflected in the hub status endpoint and the device becomes
unresponsive.

Prevent high-bandwidth transactions from being started too late in a
frame. The mechanism is not guaranteed: a combination of bit stuffing
and hub latency may still result in a device overrunning.

fiq_fsm: fix bounce buffer utilisation for Isochronous OUT

Multi-packet isochronous OUT transactions were subject to a few bounday
bugs. Fix them.

Audio playback is now much more robust: however, an issue stands with
devices that have adaptive sinks - ALSA plays samples too fast.

dwc_otg: Return full-speed frame numbers in HS mode

The frame counter increments on every *microframe* in high-speed mode.
Most device drivers expect this number to be in full-speed frames - this
caused considerable confusion to e.g. snd_usb_audio which uses the
frame counter to estimate the number of samples played.

fiq_fsm: save PID on completion of interrupt OUT transfers

Also add edge case handling for interrupt transports.

Note that for periodic split IN, data toggles are unimplemented in the
OTG host hardware - it unconditionally accepts any PID.

fiq_fsm: add missing case for fiq_fsm_tt_in_use()

Certain combinations of bitrate and endpoint activity could
result in a periodic transaction erroneously getting started
while the previous Isochronous OUT was still active.

fiq_fsm: clear hcintmsk for aborted transactions

Prevents the FIQ from erroneously handling interrupts
on a timed out channel.

fiq_fsm: enable by default

fiq_fsm: fix dequeues for non-periodic split transactions

If a dequeue happened between the SSPLIT and CSPLIT phases of the
transaction, the HCD would never receive an interrupt.

fiq_fsm: Disable by default

fiq_fsm: Handle HC babble errors

The HCTSIZ transfer size field raises a babble interrupt if
the counter wraps. Handle the resulting interrupt in this case.

dwc_otg: fix interrupt registration for fiq_enable=0

Additionally make the module parameter conditional for wherever
hcd->fiq_state is touched.

fiq_fsm: Enable by default

dwc_otg: Fix various issues with root port and transaction errors

Process the host port interrupts correctly (and don't trample them).
Root port hotplug now functional again.

Fix a few thinkos with the transaction error passthrough for fiq_fsm.

fiq_fsm: Implement hack for Split Interrupt transactions

Hubs aren't too picky about which endpoint we send Control type split
transactions to. By treating Interrupt transfers as Control, it is
possible to use the non-periodic queue in the OTG core as well as the
non-periodic FIFOs in the hub itself. This massively reduces the
microframe exclusivity/contention that periodic split transactions
otherwise have to enforce.

It goes without saying that this is a fairly egregious USB specification
violation, but it works.

Original idea by Hans Petter Selasky @ FreeBSD.org.

dwc_otg: FIQ support on SMP. Set up FIQ stack and handler on Core 0 only.

dwc_otg: introduce fiq_fsm_spin(un|)lock()

SMP safety for the FIQ relies on register read-modify write cycles being
completed in the correct order. Several places in the DWC code modify
registers also touched by the FIQ. Protect these by a bare-bones lock
mechanism.

This also makes it possible to run the FIQ and IRQ handlers on different
cores.

fiq_fsm: fix build on bcm2708 and bcm2709 platforms

dwc_otg: put some barriers back where they should be for UP

bcm2709/dwc_otg: Setup FIQ on core 1 if >1 core active

dwc_otg: fixup read-modify-write in critical paths

Be more careful about read-modify-write on registers that the FIQ
also touches.

Guard fiq_fsm_spin_lock with fiq_enable check

fiq_fsm: Falling out of the state machine isn't fatal

This edge case can be hit if the port is disabled while the FIQ is
in the middle of a transaction. Make the effects less severe.

Also get rid of the useless return value.

squash: dwc_otg: Allow to build without SMP

usb: core: make overcurrent messages more prominent

Hub overcurrent messages are more serious than "debug". Increase loglevel.

usb: dwc_otg: Don't use dma_to_virt()

Commit 6ce0d20 changes dma_to_virt() which breaks this driver.
Open code the old dma_to_virt() implementation to work around this.

Limit the use of __bus_to_virt() to cases where transfer_buffer_length
is set and transfer_buffer is not set. This is done to increase the
chance that this driver will also work on ARCH_BCM2835.

transfer_buffer should not be NULL if the length is set, but the
comment in the code indicates that there are situations where this
might happen. drivers/usb/isp1760/isp1760-hcd.c also has a similar
comment pointing to a possible: 'usb storage / SCSI bug'.

Signed-off-by: Noralf Trønnes <[email protected]>

dwc_otg: Fix crash when fiq_enable=0

dwc_otg: fiq_fsm: Make high-speed isochronous strided transfers work properly

Certain low-bandwidth high-speed USB devices (specialist audio devices,
compressed-frame webcams) have packet intervals > 1 microframe.

Stride these transfers in the FIQ by using the start-of-frame interrupt
to restart the channel at the right time.

dwc_otg: Force host mode to fix incorrect compute module boards

dwc_otg: Add ARCH_BCM2835 support

Signed-off-by: Noralf Trønnes <[email protected]>

dwc_otg: Simplify FIQ irq number code

Dropping ATAGS means we can simplify the FIQ irq number code.
Also add error checking on the returned irq number.

Signed-off-by: Noralf Trønnes <[email protected]>

dwc_otg: Remove duplicate gadget probe/unregister function

dwc_otg: Properly set the HFIR

Douglas Anderson reported:

According to the most up to date version of the dwc2 databook, the FRINT
field of the HFIR register should be programmed to:
* 125 us * (PHY clock freq for HS) - 1
* 1000 us * (PHY clock freq for FS/LS) - 1

This is opposed to older versions of the doc that claimed it should be:
* 125 us * (PHY clock freq for HS)
* 1000 us * (PHY clock freq for FS/LS)

and reported lower timing jitter on a USB analyser

dcw_otg: trim xfer length when buffer larger than allocated size is received

dwc_otg: Don't free qh align buffers in atomic context

dwc_otg: Enable the hack for Split Interrupt transactions by default

dwc_otg.fiq_fsm_mask=0xF has long been a suggestion for users with audio stutters or other USB bandwidth issues.
So far we are aware of many success stories but no failure caused by this setting.
Make it a default to learn more.

See: https://www.raspberrypi.org/forums/viewtopic.php?f=28&t=70437

Signed-off-by: popcornmix <[email protected]>

dwc_otg: Use kzalloc when suitable

dwc_otg: Pass struct device to dma_alloc*()

This makes it possible to get the bus address from Device Tree.

Signed-off-by: Noralf Trønnes <[email protected]>

dwc_otg: fix summarize urb->actual_length for isochronous transfers

Kernel does not copy input data of ISO transfers to userspace
if actual_length is set only in ISO transfers and not summarized
in urb->actual_length. Fixes raspberrypi/linux#903

fiq_fsm: Use correct states when starting isoc OUT transfers

In fiq_fsm_start_next_periodic() if an isochronous OUT transfer
was selected, no regard was given as to whether this was a single-packet
transfer or a multi-packet staged transfer.

For single-packet transfers, this had the effect of repeatedly sending
OUT packets with bogus data and lengths.

Eventually if the channel was repeatedly enabled enough times, this
would lock up the OTG core and no further bus transfers would happen.

Set the FSM state up properly if we select a single-packet transfer.

Fixes https://github.com/raspberrypi/linux/issues/1842

dwc_otg: make nak_holdoff work as intended with empty queues

If URBs reading from non-periodic split endpoints were dequeued and
the last transfer from the endpoint was a NAK handshake, the resulting
qh->nak_frame value was stale which would result in unnecessarily long
polling intervals for the first subsequent transfer with a fresh URB.

Fixup qh->nak_frame in dwc_otg_hcd_urb_dequeue and also guard against
a case where a single URB is submitted to the endpoint, a NAK was
received on the transfer immediately prior to receiving data and the
device subsequently resubmits another URB past the qh->nak_frame interval.

Fixes https://github.com/raspberrypi/linux/issues/1709

dwc_otg: fix split transaction data toggle handling around dequeues

See https://github.com/raspberrypi/linux/issues/1709

Fix several issues regarding endpoint state when URBs are dequeued
- If the HCD is disconnected, flush FIQ-enabled channels properly
- Save the data toggle state for bulk endpoints if the last transfer
  from an endpoint where URBs were dequeued returned a data packet
- Reset hc->start_pkt_count properly in assign_and_init_hc()

dwc_otg: fix several potential crash sources

On root port disconnect events, the host driver state is cleared and
in-progress host channels are forcibly stopped. This doesn't play
well with the FIQ running in the background, so:
- Guard the disconnect callback with both the host spinlock and FIQ
  spinlock
- Move qtd dereference in dwc_otg_handle_hc_fsm() after the early-out
  so we don't dereference a qtd that has gone away
- Turn catch-all BUG()s in dwc_otg_handle_hc_fsm() into warnings.

dwc_otg: delete hcd->channel_lock

The lock serves no purpose as it is only held while the HCD spinlock
is already being held.

dwc_otg: remove unnecessary dma-mode channel halts on disconnect interrupt

Host channels are already halted in kill_urbs_in_qh_list() with the
subsequent interrupt processing behaving as if the URB was dequeued
via HCD callback.

There's no need to clobber the host channel registers a second time
as this exposes races between the driver and host channel resulting
in hcd->free_hc_list becoming corrupted.

dwcotg: Allow to build without FIQ on ARM64

Signed-off-by: popcornmix <[email protected]>

dwc_otg: make periodic scheduling behave properly for FS buses

If the root port is in full-speed mode, transfer times at 12mbit/s
would be calculated but matched against high-speed quotas.

Reinitialise hcd->frame_usecs[i] on each port enable event so that
full-speed bandwidth can be tracked sensibly.

Also, don't bother using the FIQ for transfers when in full-speed
mode - at the slower bus speed, interrupt frequency is reduced by
an order of magnitude.

Related issue: https://github.com/raspberrypi/linux/issues/2020

dwc_otg: fiq_fsm: Make isochronous compatibility checks work properly

Get rid of the spammy printk and local pointer mangling.
Also, there is a nominal benefit for using fiq_fsm for isochronous
transfers in FS mode (~1.1k IRQs per second vs 2.1k IRQs per second)
so remove the root port speed check.

dwc_otg: add module parameter int_ep_interval_min

Add a module parameter (defaulting to ignored) that clamps the polling rate
of high-speed Interrupt endpoints to a minimum microframe interval.

The parameter is modifiable at runtime as it is used when activating new
endpoints (such as on device connect).

dwc_otg: fiq_fsm: Add non-periodic TT exclusivity constraints

Certain hub types do not discriminate between pipe direction (IN or OUT)
when considering non-periodic transfers. Therefore these hubs get confused
if multiple transfers are issued in different directions with the same
device address and endpoint number.

Constrain queuing non-periodic split transactions so they are performed
serially in such cases.

Related: https://github.com/raspberrypi/linux/issues/2024

dwc_otg: Fixup change to DRIVER_ATTR interface

dwc_otg: Fix compilation warnings

Signed-off-by: Phil Elwell <[email protected]>

USB_DWCOTG: Disable building dwc_otg as a module (#2265)

When dwc_otg is built as a module, build will fail with the following
error:

ERROR: "DWC_TASK_HI_SCHEDULE" [drivers/usb/host/dwc_otg/dwc_otg.ko] undefined!
scripts/Makefile.modpost:91: recipe for target '__modpost' failed
make[1]: *** [__modpost] Error 1
Makefile:1199: recipe for target 'modules' failed
make: *** [modules] Error 2

Even if the error is solved by including the missing
DWC_TASK_HI_SCHEDULE function, the kernel will panic when loading
dwc_otg.

As a workaround, simply prevent user from building dwc_otg as a module
as the current kernel does not support it.

See: https://github.com/raspberrypi/linux/issues/2258

Signed-off-by: Malik Olivier Boussejra <[email protected]>

dwc_otg: New timer API

dwc_otg: Fix removed ACCESS_ONCE->READ_ONCE

dwc_otg: don't unconditionally force host mode in dwc_otg_cil_init()

Add the ability to disable force_host_mode for those that want to use
dwc_otg in both device and host modes.

dwc_otg: Fix a regression when dequeueing isochronous transfers

In 282bed95 (dwc_otg: make nak_holdoff work as intended with empty queues)
the dequeue mechanism was changed to leave FIQ-enabled transfers to run
to completion - to avoid leaving hub TT buffers with stale packets lying
around.

This broke FIQ-accelerated isochronous transfers, as this then meant that
dozens of transfers were performed after the dequeue function returned.

Restore the state machine fence for isochronous transfers.

fiq_fsm: rewind DMA pointer for OUT transactions that fail (#2288)

See: https://github.com/raspberrypi/linux/issues/2140

dwc_otg: add smp_mb() to prevent driver state corruption on boot

Occasional crashes have been seen where the FIQ code dereferences
invalid/random pointers immediately after being set up, leading to
panic on boot.

The crash occurs as the FIQ code races against hcd_init_fiq() and
the hcd_init_fiq() code races against the outstanding memory stores
from dwc_otg_hcd_init(). Use explicit barriers after touching
driver state.

usb: dwc_otg: fix memory corruption in dwc_otg driver

[Upstream commit 51b1b6491752ac066ee8d32cc66042fcc955fef6]

The move from the staging tree to the main tree exposed a
longstanding memory corruption bug in the dwc2 driver. The
reordering of the driver initialization caused the dwc2 driver
to corrupt the initialization data of the sdhci driver on the
Raspberry Pi platform, which made the bug show up.

The error is in calling to_usb_device(hsotg->dev), since ->dev
is not a member of struct usb_device. The easiest fix is to
just remove the offending code, since it is not really needed.

Thanks to Stephen Warren for tracking down the cause of this.

Reported-by: Andre Heider <[email protected]>
Tested-by: Stephen Warren <[email protected]>
Signed-off-by: Paul Zimmerman <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
[lukas: port from upstream dwc2 to out-of-tree dwc_otg driver]
Signed-off-by: Lukas Wunner <[email protected]>

usb: dwb_otg: Fix unreachable switch statement warning

This warning appears with GCC 7.3.0 from toolchains.bootlin.com:

../drivers/usb/host/dwc_otg/dwc_otg_fiq_fsm.c: In function ‘fiq_fsm_update_hs_isoc’:
../drivers/usb/host/dwc_otg/dwc_otg_fiq_fsm.c:595:61: warning: statement will never be executed [-Wswitch-unreachable]
   st->hctsiz_copy.b.xfersize = nrpackets * st->hcchar_copy.b.mps;
                                            ~~~~~~~~~~~~~~~~~^~~~

Signed-off-by: Nathan Chancellor <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

36/198 [
Author: popcornmix
Email: [email protected]
Subject: bcm2708 framebuffer driver
Date: Wed, 17 Jun 2015 17:06:34 +0100

commit 41f846476a89c327c20d07f4176ad8d6f9f2ca97 from
https://github.com/raspberrypi/linux.git

Signed-off-by: popcornmix <[email protected]>

bcm2708_fb : Implement blanking support using the mailbox property interface

bcm2708_fb: Add pan and vsync controls

bcm2708_fb: DMA acceleration for fb_copyarea

Based on http://www.raspberrypi.org/phpBB3/viewtopic.php?p=62425#p62425
Also used Simon's dmaer_master module as a reference for tweaking DMA
settings for better performance.

For now busylooping only. IRQ support might be added later.
With non-overclocked Raspberry Pi, the performance is ~360 MB/s
for simple copy or ~260 MB/s for two-pass copy (used when dragging
windows to the right).

In the case of using DMA channel 0, the performance improves
to ~440 MB/s.

For comparison, VFP optimized CPU copy can only do ~114 MB/s in
the same conditions (hindered by reading uncached source buffer).

Signed-off-by: Siarhei Siamashka <[email protected]>

bcm2708_fb: report number of dma copies

Add a counter (exported via debugfs) reporting the
number of dma copies that the framebuffer driver
has done, in order to help evaluate different
optimization strategies.

Signed-off-by: Luke Diamand <[email protected]>

bcm2708_fb: use IRQ for DMA copies

The copyarea ioctl() uses DMA to speed things along. This
was busy-waiting for completion. This change supports using
an interrupt instead for larger transfers. For small
transfers, busy-waiting is still likely to be faster.

Signed-off-by: Luke Diamand <[email protected]>

bcm2708: Make ioctl logging quieter

video: fbdev: bcm2708_fb: Don't panic on error

No need to panic the kernel if the video driver fails.
Just print a message and return an error.

Signed-off-by: Noralf Trønnes <[email protected]>

fbdev: bcm2708_fb: Add ARCH_BCM2835 support

Add Device Tree support.
Pass the device to dma_alloc_coherent() in order to get the
correct bus address on ARCH_BCM2835.
Use the new DMA legacy API header file.
Including <mach/platform.h> is not necessary.

Signed-off-by: Noralf Trønnes <[email protected]>

BCM270x_DT: Add bcm2708-fb device

Add bcm2708-fb to Device Tree and don't add the
platform device when booting in DT mode.

Signed-off-by: Noralf Trønnes <[email protected]>

Cleanup of bcm2708_fb file to kernel coding standards

Some minor change to function - remove a use of
in_atomic, plus replacing various debug messages
that manually specify the function name with
("%s",.__func__)

Signed-off-by: James Hughes <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

37/198 [
Author: Harm Hanemaaijer
Email: [email protected]
Subject: Speed up console framebuffer imageblit function
Date: Thu, 20 Jun 2013 20:21:39 +0200

commit 6c6013eb1f705f1a88ffd9d58898b780944ffff7 from
https://github.com/raspberrypi/linux.git

Especially on platforms with a slower CPU but a relatively high
framebuffer fill bandwidth, like current ARM devices, the existing
console monochrome imageblit function used to draw console text is
suboptimal for common pixel depths such as 16bpp and 32bpp. The existing
code is quite general and can deal with several pixel depths. By creating
special case functions for 16bpp and 32bpp, by far the most common pixel
formats used on modern systems, a significant speed-up is attained
which can be readily felt on ARM-based devices like the Raspberry Pi
and the Allwinner platform, but should help any platform using the
fb layer.

The special case functions allow constant folding, eliminating a number
of instructions including divide operations, and allow the use of an
unrolled loop, eliminating instructions with a variable shift size,
reducing source memory access instructions, and eliminating excessive
branching. These unrolled loops also allow much better code optimization
by the C compiler. The code that selects which optimized variant is used
is also simplified, eliminating integer divide instructions.

The speed-up, measured by timing 'cat file.txt' in the console, varies
between 40% and 70%, when testing on the Raspberry Pi and Allwinner
ARM-based platforms, depending on font size and the pixel depth, with
the greater benefit for 32bpp.

Signed-off-by: Harm Hanemaaijer <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

38/198 [
Author: Florian Meier
Email: [email protected]
Subject: dmaengine: Add support for BCM2708
Date: Fri, 22 Nov 2013 14:22:53 +0100

commit 21a82154bec1da81481136e42dee9df8ce52ac8d from
https://github.com/raspberrypi/linux.git

Add support for DMA controller of BCM2708 as used in the Raspberry Pi.
Currently it only supports cyclic DMA.

Signed-off-by: Florian Meier <[email protected]>

dmaengine: expand functionality by supporting scatter/gather transfers sdhci-bcm2708 and dma.c: fix for LITE channels

DMA: fix cyclic LITE length overflow bug

dmaengine: bcm2708: Remove chancnt affectations

Mirror bcm2835-dma.c commit 9eba5536a7434c69d8c185d4bd1c70734d92287d:
chancnt is already filled by dma_async_device_register, which uses the channel
list to know how much channels there is.

Since it's already filled, we can safely remove it from the drivers' probe
function.

Signed-off-by: Noralf Trønnes <[email protected]>

dmaengine: bcm2708: overwrite dreq only if it is not set

dreq is set when the DMA channel is fetched from Device Tree.
slave_id is set using dmaengine_slave_config().
Only overwrite dreq with slave_id if it is not set.

dreq/slave_id in the cyclic DMA case is not touched, because I don't
have hardware to test with.

Signed-off-by: Noralf Trønnes <[email protected]>

dmaengine: bcm2708: do device registration in the board file

Don't register the device in the driver. Do it in the board file.

Signed-off-by: Noralf Trønnes <[email protected]>

dmaengine: bcm2708: don't restrict DT support to ARCH_BCM2835

Both ARCH_BCM2835 and ARCH_BCM270x are built with OF now.
Add Device Tree support to the non ARCH_BCM2835 case.
Use the same driver name regardless of architecture.

Signed-off-by: Noralf Trønnes <[email protected]>

BCM270x_DT: add bcm2835-dma entry

Add Device Tree entry for bcm2835-dma.
The entry doesn't contain any resources since they are handled
by the arch/arm/mach-bcm270x/dma.c driver.
In non-DT mode, don't add the device in the board file.

Signed-off-by: Noralf Trønnes <[email protected]>

bcm2708-dmaengine: Add debug options

BCM270x: Add memory and irq resources to dmaengine device and DT

Prepare for merging of the legacy DMA API arch driver dma.c
with bcm2708-dmaengine by adding memory and irq resources both
to platform file device and Device Tree node.
Don't use BCM_DMAMAN_DRIVER_NAME so we don't have to include mach/dma.h

Signed-off-by: Noralf Trønnes <[email protected]>

dmaengine: bcm2708: Merge with arch dma.c driver and disable dma.c

Merge the legacy DMA API driver with bcm2708-dmaengine.
This is done so we can use bcm2708_fb on ARCH_BCM2835 (mailbox
driver is also needed).

Changes to the dma.c code:
- Use BIT() macro.
- Cutdown some comments to one line.
- Add mutex to vc_dmaman and use this, since the dev lock is locked
  during probing of the engine part.
- Add global g_dmaman variable since drvdata is used by the engine part.
- Restructure for readability:
  vc_dmaman_chan_alloc()
  vc_dmaman_chan_free()
  bcm_dma_chan_free()
- Restructure bcm_dma_chan_alloc() to simplify error handling.
- Use device irq resources instead of hardcoded bcm_dma_irqs table.
- Remove dev_dmaman_register() and code it directly.
- Remove dev_dmaman_deregister() and code it directly.
- Simplify bcm_dmaman_probe() using devm_* functions.
- Get dmachans from DT if available.
- Keep 'dma.dmachans' module argument name for backwards compatibility.

Make it available on ARCH_BCM2835 as well.

Signed-off-by: Noralf Trønnes <[email protected]>

dmaengine: bcm2708: set residue_granularity field

bcm2708-dmaengine supports residue reporting at burst level
but didn't report this via the residue_granularity field.

Without this field set properly we get playback issues with I2S cards.

dmaengine: bcm2708-dmaengine: Fix memory leak when stopping a running transfer

bcm2708-dmaengine: Use more DMA channels (but not 12)

1) Only the bcm2708_fb drivers uses the legacy DMA API, and
it requires a BULK-capable channel, so all other types
(FAST, NORMAL and LITE) can be made available to the regular
DMA API.

2) DMA channels 11-14 share an interrupt. The driver can't
handle this, so don't use channels 12-14 (12 was used, probably
because it appears to have an interrupt, but in reality that
interrupt is for activity on ANY channel). This may explain
a lockup encountered when running out of DMA channels.

The combined effect of this patch is to leave 7 DMA channels
available + channel 0 for bcm2708_fb via the legacy API.

See: https://github.com/raspberrypi/linux/issues/1110
     https://github.com/raspberrypi/linux/issues/1108

dmaengine: bcm2708: Make legacy API available for bcm2835-dma

bcm2708_fb uses the legacy DMA API, so in order to start using
bcm2835-dma, bcm2835-dma has to support the legacy API. Make this
possible by exporting bcm_dmaman_probe() and bcm_dmaman_remove().

Signed-off-by: Noralf Trønnes <[email protected]>

dmaengine: bcm2708: Change DT compatible string

Both bcm2835-dma and bcm2708-dmaengine have the same compatible string.
So change compatible to "brcm,bcm2708-dma".

Signed-off-by: Noralf Trønnes <[email protected]>

dmaengine: bcm2708: Remove driver but keep legacy API

Dropping non-DT support means we don't need this driver,
but we still need the legacy DMA API.

Signed-off-by: Noralf Trønnes <[email protected]>

bcm2708-dmaengine - Fix arm64 portability/build issues

dma-bcm2708: Fix module compilation of CONFIG_DMA_BCM2708

bcm2708-dmaengine.c defines functions like bcm_dma_start which are
defined as well in dma-bcm2708.h as inline versions when
CONFIG_DMA_BCM2708 is not defined. This works fine when
CONFIG_DMA_BCM2708 is built in, but when it is selected as module build
fails with redefinition errors because in the build system when
CONFIG_DMA_BCM2708 is selected as module, the macro becomes
CONFIG_DMA_BCM2708_MODULE.

This patch makes the header use CONFIG_DMA_BCM2708_MODULE too when
available.

Fixes https://github.com/raspberrypi/linux/issues/2056

Signed-off-by: Andrei Gherzan <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
]

39/198 [
Author: gellert
Email: [email protected]
Subject: MMC: added alternative MMC driver
Date: Fri, 15 Aug 2014 16:35:06 +0100

commit db9a911de0b80f25fbe9c451a30e96a73bde90fb from
https://github.com/raspberrypi/linux.git

mmc: Disable CMD23 transfers on all cards

Pending wire-level investigation of these types of transfers
and associated errors on bcm2835-mmc, disable for now. Fallback of
CMD18/CMD25 transfers will be used automatically by the MMC layer.

Reported/Tested-by: Gellert Weisz <[email protected]>

mmc: bcm2835-mmc: enable DT support for all architectures

Both ARCH_BCM2835 and ARCH_BCM270x are built with OF now.
Enable Device Tree support for all architectures.

Signed-off-by: Noralf Trønnes <[email protected]>

mmc: bcm2835-mmc: fix probe error handling

Probe error handling is broken in several places.
Simplify error handling by using device managed functions.
Replace pr_{err,info} with dev_{err,info}.

Signed-off-by: Noralf Trønnes <[email protected]>

bcm2835-mmc: Add locks when accessing sdhost registers

bcm2835-mmc: Add range of debug options for slowing things down

bcm2835-mmc: Add option to disable some delays

bcm2835-mmc: Add option to disable MMC_QUIRK_BLK_NO_CMD23

bcm2835-mmc: Default to disabling MMC_QUIRK_BLK_NO_CMD23

bcm2835-mmc: Adding overclocking option

Allow a different clock speed to be substitued for a requested 50MHz.
This option is exposed using the "overclock_50" DT parameter.
Note that the mmc interface is restricted to EVEN integer divisions of
250MHz, and the highest sensible option is 63 (250/4 = 62.5), the
next being 125 (250/2) which is much too high.

Use at your own risk.

bcm2835-mmc: Round up the overclock, so 62 works for 62.5Mhz

Also only warn once for each overclock setting.

mmc: bcm2835-mmc: Make available on ARCH_BCM2835

Make the bcm2835-mmc driver available for use on ARCH_BCM2835.

Signed-off-by: Noralf Trønnes <[email protected]>

BCM270x_DT: add bcm2835-mmc entry

Add Device Tree entry for bcm2835-mmc.
In non-DT mode, don't add the device in the board file.

Signed-off-by: Noralf Trønnes <[email protected]>

bcm2835-mmc: Don't overwrite MMC capabilities from DT

bcm2835-mmc: Don't override bus width capabilities from devicetree

Take out the force setting of the MMC_CAP_4_BIT_DATA host capability
so that the result read from devicetree via mmc_of_parse() is
preserved.

bcm2835-mmc: Only claim one DMA channel

With both MMC controllers enabled there are few DMA channels left. The
bcm2835-mmc driver only uses DMA in one direction at a time, so it
doesn't need to claim two channels.

See: https://github.com/raspberrypi/linux/issues/1327

Signed-off-by: Phil Elwell <[email protected]>

bcm2835-mmc: New timer API

mmc: bcm2835-mmc: Support underclocking

Support underclocking of the SD bus using the max-frequency DT property
(which currently has no DT parameter). The sd_overclock parameter
already provides another way to achieve the same thing which should be
equivalent in end result, but it is a bug not to support max-frequency
as well.

See: https://github.com/raspberrypi/linux/issues/2350

Signed-off-by: Phil Elwell <[email protected]>
[Xulin: Rename SDHCI_ACMD12_ERR to SDHCI_AUTO_CMD_STATUS]
Signed-off-by: Xulin Sun <[email protected]>
]

40/198 [
Author: Phil Elwell
Email: [email protected]
Subject: Adding bcm2835-sdhost driver, and an overlay to enable it
Date: Wed, 25 Mar 2015 17:49:47 +0000

commit 1076e1aee13487206ca3406bd143a2f4180d745e from
https://github.com/raspberrypi/linux.git

BCM2835 has two SD card interfaces. This driver uses the other one.

bcm2835-sdhost: Error handling fix, and code clarification

bcm2835-sdhost: Adding overclocking option

Allow a different clock speed to be substitued for a requested 50MHz.
This option is exposed using the "overclock_50" DT parameter.
Note that the sdhost interface is restricted to integer divisions of
core_freq, and the highest sensible option for a core_freq of 250MHz
is 84 (250/3 = 83.3MHz), the next being 125 (250/2) which is much too
high.

Use at your own risk.

bcm2835-sdhost: Round up the overc…
mseaster-wr pushed a commit to WindRiver-Labs/linux-yocto-4.18 that referenced this issue Aug 5, 2019
commit 04313c2a5fe850e7cf3ba246dad6a9b7448c626b from
https://github.com/raspberrypi/linux.git

Select software CS in bcm2708_common.dtsi, and disable the automatic
conversion in the driver to allow hardware CS to be re-enabled with an
overlay.

See: raspberrypi/linux#1547

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
mseaster-wr pushed a commit to WindRiver-Labs/linux-yocto-4.18 that referenced this issue Aug 5, 2019
commit 04313c2a5fe850e7cf3ba246dad6a9b7448c626b from
https://github.com/raspberrypi/linux.git

Select software CS in bcm2708_common.dtsi, and disable the automatic
conversion in the driver to allow hardware CS to be re-enabled with an
overlay.

See: raspberrypi/linux#1547

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Xulin Sun <[email protected]>
big-henry pushed a commit to big-henry/mirror_ubuntu-bionic-kernel that referenced this issue Feb 17, 2020
Select software CS in bcm2708_common.dtsi, and disable the automatic
conversion in the driver to allow hardware CS to be re-enabled with an
overlay.

See: raspberrypi/linux#1547

Signed-off-by: Phil Elwell <[email protected]>
YadongQi pushed a commit to YadongQi/ubuntu-bionic that referenced this issue Mar 10, 2020
Select software CS in bcm2708_common.dtsi, and disable the automatic
conversion in the driver to allow hardware CS to be re-enabled with an
overlay.

See: raspberrypi/linux#1547

Signed-off-by: Phil Elwell <[email protected]>
hisenyiu2015 pushed a commit to hisenyiu2015/msm-4.14 that referenced this issue May 20, 2021
Select software CS in bcm2708_common.dtsi, and disable the automatic
conversion in the driver to allow hardware CS to be re-enabled with an
overlay.

See: raspberrypi/linux#1547

Signed-off-by: Phil Elwell <[email protected]>
hisenyiu2015 pushed a commit to hisenyiu2015/msm-4.14 that referenced this issue May 20, 2021
jai-raptee pushed a commit to jai-raptee/iliteck1 that referenced this issue Apr 30, 2024
Select software CS in bcm2708_common.dtsi, and disable the automatic
conversion in the driver to allow hardware CS to be re-enabled with an
overlay.

See: raspberrypi/linux#1547

Signed-off-by: Phil Elwell <[email protected]>
jai-raptee pushed a commit to jai-raptee/iliteck1 that referenced this issue Apr 30, 2024
Select software CS in bcm2708_common.dtsi, and disable the automatic
conversion in the driver to allow hardware CS to be re-enabled with an
overlay.

See: raspberrypi/linux#1547

Signed-off-by: Phil Elwell <[email protected]>
jai-raptee pushed a commit to jai-raptee/iliteck1 that referenced this issue Apr 30, 2024
Select software CS in bcm2708_common.dtsi, and disable the automatic
conversion in the driver to allow hardware CS to be re-enabled with an
overlay.

See: raspberrypi/linux#1547

Signed-off-by: Phil Elwell <[email protected]>
jai-raptee pushed a commit to jai-raptee/iliteck1 that referenced this issue Apr 30, 2024
Select software CS in bcm2708_common.dtsi, and disable the automatic
conversion in the driver to allow hardware CS to be re-enabled with an
overlay.

See: raspberrypi/linux#1547

Signed-off-by: Phil Elwell <[email protected]>
Clome pushed a commit to Clome/ubuntu-kernel that referenced this issue Jul 2, 2024
Select software CS in bcm2708_common.dtsi, and disable the automatic
conversion in the driver to allow hardware CS to be re-enabled with an
overlay.

See: raspberrypi/linux#1547

Signed-off-by: Phil Elwell <[email protected]>
Signed-off-by: Seth Forshee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests