Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amba-pl011 platform_driver bug #6379

Closed
TopgunZh opened this issue Sep 20, 2024 · 2 comments
Closed

amba-pl011 platform_driver bug #6379

TopgunZh opened this issue Sep 20, 2024 · 2 comments

Comments

@TopgunZh
Copy link

Describe the bug

You missed platform_driver_unregister in the pl011_exit function

Steps to reproduce the behaviour

1.sudo rmmod amba-pl011.ko.xz
2.sudo insmod amba-pl011.ko.xz

miss platform_driver_unregister(&pl011_axi_platform_driver);

Device (s)

Raspberry Pi 5

System

image

Logs

image

Additional context

No response
popcornmix added a commit to popcornmix/linux that referenced this issue Sep 20, 2024
@popcornmix
tty/serial: pl011: Also unregister pl011_axi_platform_driver
fbb3cdd 
See: raspberrypi#6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix added a commit to popcornmix/linux that referenced this issue Sep 20, 2024
@popcornmix
tty/serial: pl011: Also unregister pl011_axi_platform_driver
5f9961d 
See: raspberrypi#6379
Signed-off-by: Dom Cobley <[email protected]>
@popcornmix popcornmix mentioned this issue Sep 20, 2024
Merged
@popcornmix
Copy link
Collaborator

Does #6380 work for you?

@TopgunZh
Copy link
Author

Does #6380 work for you?
It had already been fixed when I opened the issue. The bug is relatively simple.

pelwell pushed a commit that referenced this issue Sep 24, 2024
@popcornmix @pelwell
tty/serial: pl011: Also unregister pl011_axi_platform_driver
0fb3c83 
See: #6379
Signed-off-by: Dom Cobley <[email protected]>
pelwell pushed a commit that referenced this issue Sep 25, 2024
@popcornmix @pelwell
tty/serial: pl011: Also unregister pl011_axi_platform_driver
ddec1ce 
See: #6379
Signed-off-by: Dom Cobley <[email protected]>
pelwell pushed a commit that referenced this issue Sep 25, 2024
@popcornmix @pelwell
tty/serial: pl011: Also unregister pl011_axi_platform_driver
932d82b 
See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix added a commit that referenced this issue Oct 2, 2024
@popcornmix
tty/serial: pl011: Also unregister pl011_axi_platform_driver
7ad28d8 
See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix added a commit that referenced this issue Oct 2, 2024
@popcornmix
tty/serial: pl011: Also unregister pl011_axi_platform_driver
066e19a 
See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix pushed a commit that referenced this issue Oct 7, 2024
@pelwell @popcornmix
serial: pl011: rp1 uart support
00dc4ed 
Signed-off-by: Phil Elwell <[email protected]>

ARM: pl011: Add rs485 to the RP1 support

pl011_axi_probe, added for RP1 support, lacks the rs485 additions that
appeared during its development.

Signed-off-by: Phil Elwell <[email protected]>

tty/serial: pl011: restrict RX burst FIFO threshold

If the associated DMA controller has lower burst length support than the
level the FIFO is set to, then bytes will be left in the RX FIFO at the
end of a DMA block - requiring a round-trip through the timeout interrupt
handler rather than an end-of-block DMA interrupt.

Signed-off-by: Jonathan Bell <[email protected]>

tty/serial: pl011: Also unregister pl011_axi_platform_driver

See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix added a commit that referenced this issue Oct 10, 2024
@popcornmix
tty/serial: pl011: Also unregister pl011_axi_platform_driver
844a9d2 
See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix added a commit that referenced this issue Oct 10, 2024
@popcornmix
tty/serial: pl011: Also unregister pl011_axi_platform_driver
9f681b9 
See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix pushed a commit that referenced this issue Oct 14, 2024
@pelwell @popcornmix
serial: pl011: rp1 uart support
b1394f5 
Signed-off-by: Phil Elwell <[email protected]>

ARM: pl011: Add rs485 to the RP1 support

pl011_axi_probe, added for RP1 support, lacks the rs485 additions that
appeared during its development.

Signed-off-by: Phil Elwell <[email protected]>

tty/serial: pl011: restrict RX burst FIFO threshold

If the associated DMA controller has lower burst length support than the
level the FIFO is set to, then bytes will be left in the RX FIFO at the
end of a DMA block - requiring a round-trip through the timeout interrupt
handler rather than an end-of-block DMA interrupt.

Signed-off-by: Jonathan Bell <[email protected]>

tty/serial: pl011: Also unregister pl011_axi_platform_driver

See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix pushed a commit that referenced this issue Oct 14, 2024
@pelwell @popcornmix
serial: pl011: rp1 uart support
4cd45dc 
Signed-off-by: Phil Elwell <[email protected]>

ARM: pl011: Add rs485 to the RP1 support

pl011_axi_probe, added for RP1 support, lacks the rs485 additions that
appeared during its development.

Signed-off-by: Phil Elwell <[email protected]>

tty/serial: pl011: restrict RX burst FIFO threshold

If the associated DMA controller has lower burst length support than the
level the FIFO is set to, then bytes will be left in the RX FIFO at the
end of a DMA block - requiring a round-trip through the timeout interrupt
handler rather than an end-of-block DMA interrupt.

Signed-off-by: Jonathan Bell <[email protected]>

tty/serial: pl011: Also unregister pl011_axi_platform_driver

See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix added a commit that referenced this issue Oct 17, 2024
@popcornmix
tty/serial: pl011: Also unregister pl011_axi_platform_driver
320f5b4 
See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix pushed a commit that referenced this issue Oct 21, 2024
@pelwell @popcornmix
serial: pl011: rp1 uart support
ea56508 
Signed-off-by: Phil Elwell <[email protected]>

ARM: pl011: Add rs485 to the RP1 support

pl011_axi_probe, added for RP1 support, lacks the rs485 additions that
appeared during its development.

Signed-off-by: Phil Elwell <[email protected]>

tty/serial: pl011: restrict RX burst FIFO threshold

If the associated DMA controller has lower burst length support than the
level the FIFO is set to, then bytes will be left in the RX FIFO at the
end of a DMA block - requiring a round-trip through the timeout interrupt
handler rather than an end-of-block DMA interrupt.

Signed-off-by: Jonathan Bell <[email protected]>

tty/serial: pl011: Also unregister pl011_axi_platform_driver

See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix added a commit that referenced this issue Oct 23, 2024
@popcornmix
tty/serial: pl011: Also unregister pl011_axi_platform_driver
5a2715b 
See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix pushed a commit that referenced this issue Oct 28, 2024
@pelwell @popcornmix
serial: pl011: rp1 uart support
bee20b2 
Signed-off-by: Phil Elwell <[email protected]>

ARM: pl011: Add rs485 to the RP1 support

pl011_axi_probe, added for RP1 support, lacks the rs485 additions that
appeared during its development.

Signed-off-by: Phil Elwell <[email protected]>

tty/serial: pl011: restrict RX burst FIFO threshold

If the associated DMA controller has lower burst length support than the
level the FIFO is set to, then bytes will be left in the RX FIFO at the
end of a DMA block - requiring a round-trip through the timeout interrupt
handler rather than an end-of-block DMA interrupt.

Signed-off-by: Jonathan Bell <[email protected]>

tty/serial: pl011: Also unregister pl011_axi_platform_driver

See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix added a commit that referenced this issue Nov 1, 2024
@popcornmix
tty/serial: pl011: Also unregister pl011_axi_platform_driver
005c353 
See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix pushed a commit that referenced this issue Nov 5, 2024
@pelwell @popcornmix
serial: pl011: rp1 uart support
9d68d13 
Signed-off-by: Phil Elwell <[email protected]>

ARM: pl011: Add rs485 to the RP1 support

pl011_axi_probe, added for RP1 support, lacks the rs485 additions that
appeared during its development.

Signed-off-by: Phil Elwell <[email protected]>

tty/serial: pl011: restrict RX burst FIFO threshold

If the associated DMA controller has lower burst length support than the
level the FIFO is set to, then bytes will be left in the RX FIFO at the
end of a DMA block - requiring a round-trip through the timeout interrupt
handler rather than an end-of-block DMA interrupt.

Signed-off-by: Jonathan Bell <[email protected]>

tty/serial: pl011: Also unregister pl011_axi_platform_driver

See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix pushed a commit that referenced this issue Nov 6, 2024
@pelwell @popcornmix
serial: pl011: rp1 uart support
f670c96 
Signed-off-by: Phil Elwell <[email protected]>

ARM: pl011: Add rs485 to the RP1 support

pl011_axi_probe, added for RP1 support, lacks the rs485 additions that
appeared during its development.

Signed-off-by: Phil Elwell <[email protected]>

tty/serial: pl011: restrict RX burst FIFO threshold

If the associated DMA controller has lower burst length support than the
level the FIFO is set to, then bytes will be left in the RX FIFO at the
end of a DMA block - requiring a round-trip through the timeout interrupt
handler rather than an end-of-block DMA interrupt.

Signed-off-by: Jonathan Bell <[email protected]>

tty/serial: pl011: Also unregister pl011_axi_platform_driver

See: #6379
Signed-off-by: Dom Cobley <[email protected]>
popcornmix added a commit that referenced this issue Nov 8, 2024
@popcornmix
tty/serial: pl011: Also unregister pl011_axi_platform_driver
34e76be 
See: #6379
Signed-off-by: Dom Cobley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@popcornmix @TopgunZh